From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 03/13] btrfs: Fix function description format
Date: Tue, 19 Jan 2021 14:26:39 +0200 [thread overview]
Message-ID: <20210119122649.187778-4-nborisov@suse.com> (raw)
In-Reply-To: <20210119122649.187778-1-nborisov@suse.com>
This fixes following W=1 warnings:
fs/btrfs/file-item.c:27: warning: Cannot understand * @inode: the inode we want to update the disk_i_size for
on line 27 - I thought it was a doc line
fs/btrfs/file-item.c:65: warning: Cannot understand * @inode - the inode we're modifying
on line 65 - I thought it was a doc line
fs/btrfs/file-item.c:91: warning: Cannot understand * @inode - the inode we're modifying
on line 91 - I thought it was a doc line
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/file-item.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c
index 6ccfc019ad90..868b27e887b1 100644
--- a/fs/btrfs/file-item.c
+++ b/fs/btrfs/file-item.c
@@ -24,8 +24,10 @@
PAGE_SIZE))
/**
- * @inode - the inode we want to update the disk_i_size for
- * @new_i_size - the i_size we want to set to, 0 if we use i_size
+ * btrfs_inode_safe_disk_i_size_write
+ *
+ * @inode: the inode we want to update the disk_i_size for
+ * @new_i_size: the i_size we want to set to, 0 if we use i_size
*
* With NO_HOLES set this simply sets the disk_is_size to whatever i_size_read()
* returns as it is perfectly fine with a file that has holes without hole file
@@ -62,9 +64,11 @@ void btrfs_inode_safe_disk_i_size_write(struct btrfs_inode *inode, u64 new_i_siz
}
/**
- * @inode - the inode we're modifying
- * @start - the start file offset of the file extent we've inserted
- * @len - the logical length of the file extent item
+ * btrfs_inode_set_file_extent_range
+ *
+ * @inode: the inode we're modifying
+ * @start: the start file offset of the file extent we've inserted
+ * @len: the logical length of the file extent item
*
* Call when we are inserting a new file extent where there was none before.
* Does not need to call this in the case where we're replacing an existing file
@@ -88,9 +92,11 @@ int btrfs_inode_set_file_extent_range(struct btrfs_inode *inode, u64 start,
}
/**
- * @inode - the inode we're modifying
- * @start - the start file offset of the file extent we've inserted
- * @len - the logical length of the file extent item
+ * btrfs_inode_clear_file_extent_range
+ *
+ * @inode: the inode we're modifying
+ * @start: the start file offset of the file extent we've inserted
+ * @len: the logical length of the file extent item
*
* Called when we drop a file extent, for example when we truncate. Doesn't
* need to be called for cases where we're replacing a file extent, like when
--
2.25.1
next prev parent reply other threads:[~2021-01-19 14:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 12:26 [PATCH 00/13] Make btrfs W=1 clean Nikolay Borisov
2021-01-19 12:26 ` [PATCH 01/13] btrfs: Document modified paramater of add_extent_mapping Nikolay Borisov
2021-01-19 21:25 ` Josef Bacik
2021-01-19 21:27 ` Josef Bacik
2021-01-19 12:26 ` [PATCH 02/13] btrfs: Fix parameter description of btrfs_add_extent_mapping Nikolay Borisov
2021-01-19 12:26 ` Nikolay Borisov [this message]
2021-01-19 22:43 ` [PATCH 03/13] btrfs: Fix function description format David Sterba
2021-01-19 12:26 ` [PATCH 04/13] btrfs: Fix paramter description in delayed-ref.c functions Nikolay Borisov
2021-01-19 21:26 ` Josef Bacik
2021-01-19 12:26 ` [PATCH 05/13] btrfs: Improve parameter description for __btrfs_write_out_cache Nikolay Borisov
2021-01-19 12:26 ` [PATCH 06/13] btrfs: Document now parameter of peek_discard_list Nikolay Borisov
2021-01-19 22:46 ` David Sterba
2021-01-19 12:26 ` [PATCH 07/13] btrfs: Document fs_info in btrfs_rmap_block Nikolay Borisov
2021-01-19 22:47 ` David Sterba
2021-01-19 12:26 ` [PATCH 08/13] btrfs: Fix description format of fs_info parameter of btrfs_wait_on_delayed_iputs Nikolay Borisov
2021-01-19 12:26 ` [PATCH 09/13] btrfs: Document btrfs_check_shared parameters Nikolay Borisov
2021-01-19 12:26 ` [PATCH 10/13] btrfs: Fix parameter description of btrfs_inode_rsv_release/btrfs_delalloc_release_space Nikolay Borisov
2021-01-19 12:26 ` [PATCH 11/13] btrfs: Fix parameter description in space-info.c Nikolay Borisov
2021-01-19 12:26 ` [PATCH 12/13] btrfs: Fix parameter description for functions in extent_io.c Nikolay Borisov
2021-01-19 12:26 ` [PATCH 13/13] lib/zstd: Convert constants to defines Nikolay Borisov
2021-01-19 22:39 ` [PATCH 00/13] Make btrfs W=1 clean David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119122649.187778-4-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox