From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH v3 10/14] btrfs: Fix parameter description of btrfs_inode_rsv_release/btrfs_delalloc_release_space
Date: Fri, 22 Jan 2021 11:58:01 +0200 [thread overview]
Message-ID: <20210122095805.620458-11-nborisov@suse.com> (raw)
In-Reply-To: <20210122095805.620458-1-nborisov@suse.com>
Fixes following warnings:
fs/btrfs/delalloc-space.c:205: warning: Function parameter or member 'inode' not described in 'btrfs_inode_rsv_release'
fs/btrfs/delalloc-space.c:205: warning: Function parameter or member 'qgroup_free' not described in 'btrfs_inode_rsv_release'
fs/btrfs/delalloc-space.c:472: warning: Function parameter or member 'reserved' not described in 'btrfs_delalloc_release_space'
fs/btrfs/delalloc-space.c:472: warning: Function parameter or member 'qgroup_free' not described in 'btrfs_delalloc_release_space'
fs/btrfs/delalloc-space.c:472: warning: Excess function parameter 'release_bytes' description in 'btrfs_delalloc_release_space'
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/delalloc-space.c | 29 +++++++++++++++++------------
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/fs/btrfs/delalloc-space.c b/fs/btrfs/delalloc-space.c
index bacee09b7bfd..35f25a3d897b 100644
--- a/fs/btrfs/delalloc-space.c
+++ b/fs/btrfs/delalloc-space.c
@@ -191,12 +191,14 @@ void btrfs_free_reserved_data_space(struct btrfs_inode *inode,
}
/**
- * btrfs_inode_rsv_release - release any excessive reservation.
- * @inode - the inode we need to release from.
- * @qgroup_free - free or convert qgroup meta.
- * Unlike normal operation, qgroup meta reservation needs to know if we are
- * freeing qgroup reservation or just converting it into per-trans. Normally
- * @qgroup_free is true for error handling, and false for normal release.
+ * Release any excessive reservation.
+ *
+ * @inode: the inode we need to release from.
+ * @qgroup_free: free or convert qgroup meta. Unlike normal operation, qgroup
+ * meta reservation needs to know if we are freeing qgroup
+ * reservation or just converting it into per-trans. Normally
+ * @qgroup_free is true for error handling, and false for normal
+ * release.
*
* This is the same as btrfs_block_rsv_release, except that it handles the
* tracepoint for the reservation.
@@ -361,7 +363,8 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes)
}
/**
- * btrfs_delalloc_release_metadata - release a metadata reservation for an inode
+ * Release a metadata reservation for an inode
+ *
* @inode: the inode to release the reservation for.
* @num_bytes: the number of bytes we are releasing.
* @qgroup_free: free qgroup reservation or convert it to per-trans reservation
@@ -455,11 +458,13 @@ int btrfs_delalloc_reserve_space(struct btrfs_inode *inode,
}
/**
- * btrfs_delalloc_release_space - release data and metadata space for delalloc
- * @inode: inode we're releasing space for
- * @start: start position of the space already reserved
- * @len: the len of the space already reserved
- * @release_bytes: the len of the space we consumed or didn't use
+ * Release data and metadata space for delalloc
+ *
+ * @inode: inode we're releasing space for
+ * @reserved: list of changed/reserved ranges
+ * @start: start position of the space already reserved
+ * @len: the len of the space already reserved
+ * @qgroup_free: should qgroup reserved-space also be freed
*
* This function will release the metadata space that was not used and will
* decrement ->delalloc_bytes and remove it from the fs_info delalloc_inodes
--
2.25.1
next prev parent reply other threads:[~2021-01-22 10:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 9:57 [PATCH v3 00/14] Make btrfs W=1 clean Nikolay Borisov
2021-01-22 9:57 ` [PATCH v3 01/14] btrfs: Document modified parameter of add_extent_mapping Nikolay Borisov
2021-01-22 12:32 ` Johannes Thumshirn
2021-01-22 9:57 ` [PATCH v3 02/14] btrfs: Fix parameter description of btrfs_add_extent_mapping Nikolay Borisov
2021-01-22 12:35 ` Johannes Thumshirn
2021-01-22 9:57 ` [PATCH v3 03/14] btrfs: Fix function description format Nikolay Borisov
2021-01-22 12:38 ` Johannes Thumshirn
2021-01-22 9:57 ` [PATCH v3 04/14] btrfs: Fix parameter description in delayed-ref.c functions Nikolay Borisov
2021-01-22 13:52 ` Johannes Thumshirn
2021-01-22 9:57 ` [PATCH v3 05/14] btrfs: Improve parameter description for __btrfs_write_out_cache Nikolay Borisov
2021-01-22 9:57 ` [PATCH v3 06/14] btrfs: Document now parameter of peek_discard_list Nikolay Borisov
2021-01-22 9:57 ` [PATCH v3 07/14] btrfs: Document fs_info in btrfs_rmap_block Nikolay Borisov
2021-01-22 9:57 ` [PATCH v3 08/14] btrfs: Fix description format of fs_info parameter of btrfs_wait_on_delayed_iputs Nikolay Borisov
2021-01-22 9:58 ` [PATCH v3 09/14] btrfs: Document btrfs_check_shared parameters Nikolay Borisov
2021-01-22 9:58 ` Nikolay Borisov [this message]
2021-01-22 9:58 ` [PATCH v3 11/14] btrfs: Fix parameter description in space-info.c Nikolay Borisov
2021-01-22 9:58 ` [PATCH v3 12/14] btrfs: Fix parameter description for functions in extent_io.c Nikolay Borisov
2021-01-22 9:58 ` [PATCH v3 13/14] lib/zstd: Convert constants to defines Nikolay Borisov
2021-01-22 10:26 ` Nikolay Borisov
2021-01-23 17:50 ` Nick Terrell
2021-01-24 11:16 ` David Sterba
2021-01-22 9:58 ` [PATCH v3 14/14] btrfs: Enable W=1 checks for btrfs Nikolay Borisov
2021-01-22 16:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122095805.620458-11-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox