From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41B5C433E0 for ; Wed, 27 Jan 2021 12:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A46C20770 for ; Wed, 27 Jan 2021 12:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237584AbhA0MGb (ORCPT ); Wed, 27 Jan 2021 07:06:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:38928 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237259AbhA0MEP (ORCPT ); Wed, 27 Jan 2021 07:04:15 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 38CD3AC9B; Wed, 27 Jan 2021 12:03:34 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id CA819DA84C; Wed, 27 Jan 2021 13:01:46 +0100 (CET) Date: Wed, 27 Jan 2021 13:01:46 +0100 From: David Sterba To: matthias.bgg@kernel.org Cc: Qu Wenruo , Marek Behun , u-boot@lists.denx.de, linux-btrfs@vger.kernel.org, Matthias Brugger Subject: Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig Message-ID: <20210127120146.GZ1993@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, matthias.bgg@kernel.org, Qu Wenruo , Marek Behun , u-boot@lists.denx.de, linux-btrfs@vger.kernel.org, Matthias Brugger References: <20210127094231.11740-1-matthias.bgg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127094231.11740-1-matthias.bgg@kernel.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms") > btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select > it. This leads to compilation errors: > fs/built-in.o: In function `hash_sha256': > fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts' > fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update' > fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish' > > Signed-off-by: Matthias Brugger So this is a fix for u-boot, got me confused and not for the first time as there's Kconfig and the same fs/btrfs/ directory structure.