From: David Sterba <dsterba@suse.cz>
To: Michal Rostecki <mrostecki@suse.de>
Cc: dsterba@suse.cz, Josef Bacik <josef@toxicpanda.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Rostecki <mrostecki@suse.com>
Subject: Re: [PATCH v2] btrfs: Avoid calling btrfs_get_chunk_map() twice
Date: Fri, 29 Jan 2021 20:42:08 +0100 [thread overview]
Message-ID: <20210129194208.GM1993@twin.jikos.cz> (raw)
In-Reply-To: <20210129190241.GA18188@wotan.suse.de>
On Fri, Jan 29, 2021 at 07:02:41PM +0000, Michal Rostecki wrote:
> On Fri, Jan 29, 2021 at 06:47:53PM +0100, David Sterba wrote:
> > On Fri, Jan 29, 2021 at 05:15:21PM +0000, Michal Rostecki wrote:
> > > On Fri, Jan 29, 2021 at 11:22:48AM -0500, Josef Bacik wrote:
> > > > On 1/27/21 8:57 AM, Michal Rostecki wrote:
> > > > it happens when you run btrfs/060. Please make sure to run xfstests against
> > > > patches before you submit them upstream. Thanks,
> > > >
> > > > Josef
> > >
> > > Umm... I ran the xftests against v1 patch and didn't get that panic.
> >
> > It could have been caused by my fixups to v2 and I can reproduce the
> > crash now too. I can't see any difference besides the u64/int switch and
> > the 'goto out' removal in btrfs_bio_fits_in_stripe.
>
> I was able to fix the issue by the following diff. I will send it as the
> patch after confirming that all fstests are passing.
Thanks, can't reproduce the crash with that at least on test btrfs/060.
prev parent reply other threads:[~2021-01-29 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 13:57 [PATCH v2] btrfs: Avoid calling btrfs_get_chunk_map() twice Michal Rostecki
2021-01-27 14:08 ` Nikolay Borisov
2021-01-28 10:38 ` Filipe Manana
2021-01-28 11:00 ` David Sterba
2021-01-28 11:06 ` David Sterba
2021-01-29 16:22 ` Josef Bacik
2021-01-29 17:15 ` Michal Rostecki
2021-01-29 17:47 ` David Sterba
2021-01-29 18:59 ` Filipe Manana
2021-01-29 19:02 ` Michal Rostecki
2021-01-29 19:42 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129194208.GM1993@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrostecki@suse.com \
--cc=mrostecki@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox