* [PATCH] btrfs: fix boolreturn.cocci warnings [not found] <202101301416.gmP3XmvI-lkp@intel.com> @ 2021-01-30 6:49 ` kernel test robot 0 siblings, 0 replies; 3+ messages in thread From: kernel test robot @ 2021-01-30 6:49 UTC (permalink / raw) To: Naohiro Aota Cc: kbuild-all, David Sterba, Josef Bacik, Chris Mason, linux-btrfs, linux-kernel From: kernel test robot <lkp@intel.com> fs/btrfs/volumes.c:1462:10-11: WARNING: return of 0/1 in function 'dev_extent_hole_check_zoned' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 69e81c8e2824 ("btrfs: implement zoned chunk allocator") CC: Naohiro Aota <naohiro.aota@wdc.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- tree: https://github.com/kdave/btrfs-devel.git for-next-20210129 head: 6e043613b2c4377ce095ea826160d42031156d35 commit: 69e81c8e2824ec495071293cfebb74faca15e616 [14784/14851] btrfs: implement zoned chunk allocator volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1459,7 +1459,7 @@ static bool dev_extent_hole_check_zoned( if (ret == -ERANGE) { *hole_start += *hole_size; *hole_size = 0; - return 1; + return true; } *hole_start += zone_size; ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <202011011347.QVW3uluR-lkp@intel.com>]
* [PATCH] btrfs: fix boolreturn.cocci warnings [not found] <202011011347.QVW3uluR-lkp@intel.com> @ 2020-11-01 5:20 ` kernel test robot 2020-12-15 18:13 ` David Sterba 0 siblings, 1 reply; 3+ messages in thread From: kernel test robot @ 2020-11-01 5:20 UTC (permalink / raw) To: Josef Bacik Cc: kbuild-all, David Sterba, Nikolay Borisov, Chris Mason, linux-btrfs, linux-kernel From: kernel test robot <lkp@intel.com> fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: fc96d3794eb2 ("btrfs: rename need_do_async_reclaim") CC: Josef Bacik <josef@toxicpanda.com> Signed-off-by: kernel test robot <lkp@intel.com> --- tree: https://github.com/kdave/btrfs-devel.git for-next-20201030 head: 757db2d191a0eb51ffb9acf023e31393d731b0a9 commit: fc96d3794eb2f38f91dc1647ab55967190b68482 [14921/14978] btrfs: rename need_do_async_reclaim space-info.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/btrfs/space-info.c +++ b/fs/btrfs/space-info.c @@ -807,10 +807,10 @@ static inline bool need_preemptive_recla /* If we're just plain full then async reclaim just slows us down. */ if ((space_info->bytes_used + space_info->bytes_reserved) >= thresh) - return 0; + return false; if (!btrfs_calc_reclaim_metadata_size(fs_info, space_info)) - return 0; + return false; return (used >= thresh && !btrfs_fs_closing(fs_info) && !test_bit(BTRFS_FS_STATE_REMOUNTING, &fs_info->fs_state)); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: fix boolreturn.cocci warnings 2020-11-01 5:20 ` kernel test robot @ 2020-12-15 18:13 ` David Sterba 0 siblings, 0 replies; 3+ messages in thread From: David Sterba @ 2020-12-15 18:13 UTC (permalink / raw) To: kernel test robot Cc: Josef Bacik, kbuild-all, David Sterba, Nikolay Borisov, Chris Mason, linux-btrfs, linux-kernel On Sun, Nov 01, 2020 at 01:20:51PM +0800, kernel test robot wrote: > From: kernel test robot <lkp@intel.com> > > fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Fixes: fc96d3794eb2 ("btrfs: rename need_do_async_reclaim") > CC: Josef Bacik <josef@toxicpanda.com> > Signed-off-by: kernel test robot <lkp@intel.com> The patchset is still in a topic branch so I folded the change. There were more int/bool mismatches in other patches, that got fixed too. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-30 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202101301416.gmP3XmvI-lkp@intel.com>
2021-01-30 6:49 ` [PATCH] btrfs: fix boolreturn.cocci warnings kernel test robot
[not found] <202011011347.QVW3uluR-lkp@intel.com>
2020-11-01 5:20 ` kernel test robot
2020-12-15 18:13 ` David Sterba
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).