From: David Sterba <dsterba@suse.cz>
To: Sidong Yang <realwakka@gmail.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH v3] btrfs-progs: filesystem-resize: make output more readable
Date: Fri, 19 Feb 2021 19:11:49 +0100 [thread overview]
Message-ID: <20210219181149.GI1993@twin.jikos.cz> (raw)
In-Reply-To: <20210219171818.10170-1-realwakka@gmail.com>
On Fri, Feb 19, 2021 at 05:18:18PM +0000, Sidong Yang wrote:
> This patch make output of filesystem-resize command more readable and
> give detail information for users. This patch provides more information
> about filesystem like below.
>
> Before:
> Resize '/mnt' of '1:-1G'
>
> After:
> Resize device id 1 (/dev/vdb) from 4.00GiB to 3.00GiB
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
Code-wise it looks good, but I tried a simple test and it does not work:
# truncate -s 4g image
# mkfs.btrfs image
# mount -o loop image mnt
# btrfs fi resize -1G mnt
ERROR: cannot find devid: 0
while running the same command with the installed system 'btrfs' resizes
the fs: "Resize '.' of '-1G'".
next prev parent reply other threads:[~2021-02-19 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 17:18 [PATCH v3] btrfs-progs: filesystem-resize: make output more readable Sidong Yang
2021-02-19 18:11 ` David Sterba [this message]
2021-02-20 12:38 ` Sidong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219181149.GI1993@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox