From: Tom Rini <trini@konsulko.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de, linux-btrfs@vger.kernel.org,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>
Subject: Re: [PATCH u-boot 2/2] fs: btrfs: change directory list output to be aligned as before
Date: Thu, 25 Feb 2021 08:25:02 -0500 [thread overview]
Message-ID: <20210225132502.GU10169@bill-the-cat> (raw)
In-Reply-To: <20210209180508.22132-2-marek.behun@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Tue, Feb 09, 2021 at 07:05:08PM +0100, Marek Behún wrote:
> Since commit 325dd1f642dd ("fs: btrfs: Use btrfs_iter_dir() to ...")
> when btrfs is listing a directory, the output is not aligned:
>
> <SYMLINK> 15 Wed Sep 09 13:20:03 2020 boot.scr -> @/boot/boot.scr
> <DIR> 0 Tue Feb 02 12:42:09 2021 @
> <FILE> 108 Tue Feb 02 12:54:04 2021 1.info
>
> Return back to how it was displayed previously, i.e.:
>
> <SYM> 15 Wed Sep 09 13:20:03 2020 boot.scr -> @/boot/boot.scr
> <DIR> 0 Tue Feb 02 12:42:09 2021 @
> < > 108 Tue Feb 02 12:54:04 2021 1.info
>
> Instead of '<FILE>', print '< >', as ext4 driver.
>
> If an unknown directory item type is encountered, we will print the type
> number left padded with spaces, enclosed by '?', instead of '<' and '>',
> i.e.:
>
> ? 30? ............................. name
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Fixes: 325dd1f642dd ("fs: btrfs: Use btrfs_iter_dir() to replace ...")
> Cc: David Sterba <dsterba@suse.com>
> Cc: Qu Wenruo <wqu@suse.com>
> Cc: Tom Rini <trini@konsulko.com>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-02-25 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 18:05 [PATCH u-boot 1/2] fs: btrfs: skip xattrs in directory listing Marek Behún
2021-02-09 18:05 ` [PATCH u-boot 2/2] fs: btrfs: change directory list output to be aligned as before Marek Behún
2021-02-10 0:20 ` Qu Wenruo
2021-02-25 13:25 ` Tom Rini [this message]
2021-02-10 0:20 ` [PATCH u-boot 1/2] fs: btrfs: skip xattrs in directory listing Qu Wenruo
2021-02-25 13:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225132502.GU10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).