From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F0CC433DB for ; Thu, 4 Mar 2021 17:35:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BABF64F56 for ; Thu, 4 Mar 2021 17:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234811AbhCDRfR (ORCPT ); Thu, 4 Mar 2021 12:35:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:42086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238058AbhCDRfN (ORCPT ); Thu, 4 Mar 2021 12:35:13 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C8600AE1C for ; Thu, 4 Mar 2021 17:34:32 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id C647FDA81D; Thu, 4 Mar 2021 18:32:36 +0100 (CET) Date: Thu, 4 Mar 2021 18:32:36 +0100 From: David Sterba To: Goldwyn Rodrigues Cc: linux-btrfs@vger.kernel.org, Dave Sterba Subject: Re: [PATCH v3] btrfs: remove force argument from run_delalloc_nocow() Message-ID: <20210304173236.GT7604@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Goldwyn Rodrigues , linux-btrfs@vger.kernel.org References: <20210304150625.idi3d6gpkwwovcpz@fiona> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304150625.idi3d6gpkwwovcpz@fiona> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Mar 04, 2021 at 09:06:25AM -0600, Goldwyn Rodrigues wrote: > force_nocow can be calculated by btrfs_inode and does not need to be > passed as an argument. > > This simplifies run_delalloc_nocow() call from btrfs_run_delalloc_range() > A new function, should_nocow() checks if the range should be nocow'd or > not. The function returns true iff either BTRFS_INODE_NODATA or > BTRFS_INODE_PREALLOC, but is not a defrag extent. > > Signed-off-by: Goldwyn Rodrigues > Reviewed-by: David Sterba > Tested-by: Johannes Thumshirn > Reviewed-by: Johannes Thumshirn Added to misc-next, thanks.