From: David Sterba <dsterba@suse.cz>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: turn btrfs_destroy_delayed_refs() into void function
Date: Tue, 9 Mar 2021 13:22:48 +0100 [thread overview]
Message-ID: <20210309122248.GG7604@twin.jikos.cz> (raw)
In-Reply-To: <1615282374-29598-1-git-send-email-yang.lee@linux.alibaba.com>
On Tue, Mar 09, 2021 at 05:32:54PM +0800, Yang Li wrote:
> This function always return '0' and no callers use the return value.
> So make it a void function.
>
> This eliminates the following coccicheck warning:
> ./fs/btrfs/disk-io.c:4522:5-8: Unneeded variable: "ret". Return "0" on
> line 4530
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Can you please tell your robot to ignore this warning, I'm getting tired
to explain the same thing again,
https://lore.kernel.org/linux-btrfs/20210302120708.GH7604@suse.cz/
this is like 5th attempt to blindly fix a tool warning without
understanding the code.
next prev parent reply other threads:[~2021-03-09 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 9:32 [PATCH] btrfs: turn btrfs_destroy_delayed_refs() into void function Yang Li
2021-03-09 9:50 ` Anand Jain
2021-03-09 11:38 ` kernel test robot
2021-03-09 12:22 ` David Sterba [this message]
2021-03-09 12:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309122248.GG7604@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox