From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F226CC433B4 for ; Tue, 6 Apr 2021 12:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C76076139E for ; Tue, 6 Apr 2021 12:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343890AbhDFMSj (ORCPT ); Tue, 6 Apr 2021 08:18:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:36648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239518AbhDFMSg (ORCPT ); Tue, 6 Apr 2021 08:18:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE114B15D; Tue, 6 Apr 2021 12:18:27 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 12354DA732; Tue, 6 Apr 2021 14:16:15 +0200 (CEST) Date: Tue, 6 Apr 2021 14:16:15 +0200 From: David Sterba To: Zheng Yongjun Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] btrfs: integrity-checker: use DEFINE_MUTEX() for mutex lock Message-ID: <20210406121615.GE7604@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Zheng Yongjun , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210405101446.14990-1-zhengyongjun3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210405101446.14990-1-zhengyongjun3@huawei.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Apr 05, 2021 at 06:14:46PM +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun You've sent this patch already and haven't provided the answer why the changes should be done. https://lore.kernel.org/linux-btrfs/20210104144559.GF6430@twin.jikos.cz/