From: riteshh <riteshh@linux.ibm.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-btrfs@vger.kernel.org, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 1/2] btrfs: Remove unused function btrfs_reada_detach()
Date: Wed, 7 Apr 2021 21:23:56 +0530 [thread overview]
Message-ID: <20210407155356.7oq7dslpox7pujjs@riteshh-domain> (raw)
In-Reply-To: <20210406162404.11746-1-rgoldwyn@suse.de>
On 21/04/06 11:24AM, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> btrfs_reada_detach() is not called by any function. Remove.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> fs/btrfs/ctree.h | 1 -
> fs/btrfs/reada.c | 9 +--------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
Although not an expert in this area, but I would hopefully start doing more
reviews in btrfs and hence will be spending more time with it's code.
For this patch seems to be easy and trivial and looks fine to me.
Please feel free to add:-
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
next prev parent reply other threads:[~2021-04-07 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 16:24 [PATCH 1/2] btrfs: Remove unused function btrfs_reada_detach() Goldwyn Rodrigues
2021-04-06 16:24 ` [PATCH 2/2] btrfs: Use reada_control pointer instead of void pointer Goldwyn Rodrigues
2021-04-07 4:40 ` Anand Jain
2021-04-07 15:49 ` riteshh
2021-04-23 11:28 ` David Sterba
2021-04-06 23:59 ` [PATCH 1/2] btrfs: Remove unused function btrfs_reada_detach() Anand Jain
2021-04-07 15:53 ` riteshh [this message]
2021-04-23 11:19 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407155356.7oq7dslpox7pujjs@riteshh-domain \
--to=riteshh@linux.ibm.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).