From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3716FC433B4 for ; Thu, 29 Apr 2021 22:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1867B61464 for ; Thu, 29 Apr 2021 22:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbhD2WXz (ORCPT ); Thu, 29 Apr 2021 18:23:55 -0400 Received: from out20-14.mail.aliyun.com ([115.124.20.14]:45041 "EHLO out20-14.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbhD2WXx (ORCPT ); Thu, 29 Apr 2021 18:23:53 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08758683|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.103171-0.00494594-0.891883;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047193;MF=wangyugui@e16-tech.com;NM=1;PH=DS;RN=3;RT=3;SR=0;TI=SMTPD_---.K6J4WCv_1619734984; Received: from 192.168.2.112(mailfrom:wangyugui@e16-tech.com fp:SMTPD_---.K6J4WCv_1619734984) by smtp.aliyun-inc.com(10.147.44.145); Fri, 30 Apr 2021 06:23:04 +0800 Date: Fri, 30 Apr 2021 06:23:08 +0800 From: Wang Yugui To: Josef Bacik , linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/7] Preemptive flushing improvements In-Reply-To: <20210430054002.6E36.409509F4@e16-tech.com> References: <20210430054002.6E36.409509F4@e16-tech.com> Message-Id: <20210430062307.0CEE.409509F4@e16-tech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.03 [en] Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org Hi, > > On 4/28/21 9:48 PM, Wang Yugui wrote: > > > Hi, > > > > > > xfstests generic/562 failed with this patch. > > > > > > This is the file 562.out.bad. > > > > > It's not failing for me, what is your config like? Both the local.config and the type/size of your devices. Thanks, > > > > # cat xfstests/local.config > > dev_base_disk=/dev/disk/by-id/nvme-Dell_Express_Flash_NVMe_SM1715_800GB_SFF__S29HNYAH500207 > > export TEST_DIR=/mnt/test > > export TEST_DEV=${dev_base_disk}-part6 > export TEST_DEV=$(realpath $TEST_DEV) > > > export SCRATCH_MNT=/mnt/scratch > > export SCRATCH_DEV_POOL="${dev_base_disk}-part1 ${dev_base_disk}-part2 > ${dev_base_disk}-part3 ${dev_base_disk}-part4 ${dev_base_disk}-part5" > export SCRATCH_DEV_POOL=$(realpath $SCRATCH_DEV_POOL | xargs /bin/echo ) > > #LOGWRITES_DEV= > > > # parted /dev/disk/by-id/nvme-Dell_Express_Flash_NVMe_SM1715_800GB_SFF__S29HNYAH500207 unit s print > Model: NVMe Device (nvme) > Disk /dev/nvme0n1: 1562824368s > Sector size (logical/physical): 512B/512B > Partition Table: gpt > Disk Flags: > > Number Start End Size File system Name Flags > 1 2097152s 54525951s 52428800s btrfs primary > 2 54525952s 106954751s 52428800s primary > 3 106954752s 159383551s 52428800s primary > 4 159383552s 211812351s 52428800s primary > 5 211812352s 264241151s 52428800s primary > 6 264241152s 316669951s 52428800s btrfs primary By the way, We enable '-O no-holes -R free-space-tree' default for mkfs.btrfs. Best Regards Wang Yugui (wangyugui@e16-tech.com) 2021/04/30