Re: [PATCH v2] btrfs: mark ordered extent and inode with error if we fail to finish

[David Sterba <dsterba@suse.cz>]

On Wed, May 19, 2021 at 09:38:27AM -0400, Josef Bacik wrote:
> While doing error injection testing I saw that sometimes we'd get an
> abort that wouldn't stop the current transaction commit from completing.
> This abort was coming from finish ordered IO, but at this point in the
> transaction commit we should have gotten an error and stopped.
> 
> It turns out the abort came from finish ordered io while trying to write
> out the free space cache.  It occurred to me that any failure inside of
> finish_ordered_io isn't actually raised to the person doing the writing,
> so we could have any number of failures in this path and think the
> ordered extent completed successfully and the inode was fine.
> 
> Fix this by marking the ordered extent with BTRFS_ORDERED_IOERR, and
> marking the mapping of the inode with mapping_set_error, so any callers
> that simply call fdatawait will also get the error.
> 
> With this we're seeing the IO error on the free space inode when we fail
> to do the finish_ordered_io.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Added to misc-next, thanks.