From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH 04/10] block: remove the GENHD_FL_UP check in blkdev_get_no_open
Date: Sat, 24 Jul 2021 09:12:43 +0200 [thread overview]
Message-ID: <20210724071249.1284585-5-hch@lst.de> (raw)
In-Reply-To: <20210724071249.1284585-1-hch@lst.de>
The GENHD_FL_UP check in blkdev_get_no_open is superflous. The actual
non-racy check happens later under open_mutex in blkdev_get_by_dev,
and the inodes are removed from the inode hash early in del_gendisk,
so it does not provide any useful short cut.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/block_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 9ef4f1fc2cb0..932f4034ad66 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1340,7 +1340,7 @@ struct block_device *blkdev_get_no_open(dev_t dev)
disk = bdev->bd_disk;
if (!kobject_get_unless_zero(&disk_to_dev(disk)->kobj))
goto bdput;
- if ((disk->flags & (GENHD_FL_UP | GENHD_FL_HIDDEN)) != GENHD_FL_UP)
+ if (disk->flags & GENHD_FL_HIDDEN)
goto put_disk;
if (!try_module_get(bdev->bd_disk->fops->owner))
goto put_disk;
--
2.30.2
next prev parent reply other threads:[~2021-07-24 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 7:12 fixes and cleanups for block_device refcounting v3 Christoph Hellwig
2021-07-24 7:12 ` [PATCH 01/10] block: delay freeing the gendisk Christoph Hellwig
2021-07-24 7:12 ` [PATCH 02/10] block: assert the locking state in delete_partition Christoph Hellwig
2021-07-24 7:12 ` [PATCH 03/10] block: unhash the block device inodes earlier Christoph Hellwig
2021-07-26 10:15 ` Ming Lei
2021-07-24 7:12 ` Christoph Hellwig [this message]
2021-07-26 10:16 ` [PATCH 04/10] block: remove the GENHD_FL_UP check in blkdev_get_no_open Ming Lei
2021-07-24 7:12 ` [PATCH 05/10] block: allocate bd_meta_info later in add_partitions Christoph Hellwig
2021-07-24 7:12 ` [PATCH 06/10] block: change the refcounting for partitions Christoph Hellwig
2021-07-26 2:20 ` Damien Le Moal
2021-07-26 10:17 ` Ming Lei
2021-07-24 7:12 ` [PATCH 07/10] btrfs: store a block_device in struct btrfs_ordered_extent Christoph Hellwig
2021-07-24 7:12 ` [PATCH 08/10] loop: don't grab a reference to the block device Christoph Hellwig
2021-07-24 7:12 ` [PATCH 09/10] block: remove bdgrab Christoph Hellwig
2021-07-24 7:12 ` [PATCH 10/10] block: remove bdput Christoph Hellwig
2021-07-24 7:22 ` fixes and cleanups for block_device refcounting v3 Christoph Hellwig
2021-07-24 16:06 ` Jens Axboe
2021-07-24 16:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724071249.1284585-5-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).