Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Sidong Yang <realwakka@gmail.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: cmds: Fix build for using NAME_MAX
Date: Sat, 24 Jul 2021 08:23:56 +0000	[thread overview]
Message-ID: <20210724082356.GA68829@realwakka> (raw)
In-Reply-To: <2305182b-1e12-df9c-320c-7a7eedba860d@gmx.com>

On Sat, Jul 24, 2021 at 03:50:25PM +0800, Qu Wenruo wrote:
> 
> 
> On 2021/7/24 下午3:46, Sidong Yang wrote:
> > There is some code that using NAME_MAX but it doesn't include header
> > that is defined. This patch adds a line that includes linux/limits.h
> > which defines NAME_MAX.
> 
> I guess it's related to this issue?
> 
> https://github.com/kdave/btrfs-progs/issues/386

Yeah, It seems that there is no patch for this yet. So I sent this
patch. Is this too minor patch?

Thanks,
Sidong

> 
> Thanks,
> Qu
> 
> > 
> > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > ---
> >   cmds/filesystem-usage.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/cmds/filesystem-usage.c b/cmds/filesystem-usage.c
> > index 50d8995e..2a76e29c 100644
> > --- a/cmds/filesystem-usage.c
> > +++ b/cmds/filesystem-usage.c
> > @@ -24,6 +24,7 @@
> >   #include <stdarg.h>
> >   #include <getopt.h>
> >   #include <fcntl.h>
> > +#include <linux/limits.h>
> > 
> >   #include "common/utils.h"
> >   #include "kerncompat.h"
> > 

  reply	other threads:[~2021-07-24  8:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24  7:46 [PATCH] btrfs-progs: cmds: Fix build for using NAME_MAX Sidong Yang
2021-07-24  7:50 ` Qu Wenruo
2021-07-24  8:23   ` Sidong Yang [this message]
2021-07-24  9:44     ` Qu Wenruo
2021-07-24 15:26       ` Sidong Yang
2021-07-25  2:54     ` Su Yue
2021-07-25  7:29       ` Sidong Yang
2021-07-25  9:12       ` Qu Wenruo
2021-07-26 11:25       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210724082356.GA68829@realwakka \
    --to=realwakka@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox