* Simple question for newbie developer about qgroup
@ 2021-08-07 14:47 Sidong Yang
2021-08-07 22:50 ` Qu Wenruo
0 siblings, 1 reply; 3+ messages in thread
From: Sidong Yang @ 2021-08-07 14:47 UTC (permalink / raw)
To: linux-btrfs
I read btrfs kernel source code about qgroup. I want to know about how
works adding or deleting qgroups. and I read the function
__del_qgroup_relation() in qgroup.c.
This function checks whether dst is parent for src and store the result
in variable named found. I think if the checks failed, the function
needs to be failed or print warning message at least. Am I right? Or do
you have other intentions?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Simple question for newbie developer about qgroup
2021-08-07 14:47 Simple question for newbie developer about qgroup Sidong Yang
@ 2021-08-07 22:50 ` Qu Wenruo
2021-08-08 11:56 ` Sidong Yang
0 siblings, 1 reply; 3+ messages in thread
From: Qu Wenruo @ 2021-08-07 22:50 UTC (permalink / raw)
To: Sidong Yang, linux-btrfs
On 2021/8/7 下午10:47, Sidong Yang wrote:
> I read btrfs kernel source code about qgroup. I want to know about how
> works adding or deleting qgroups. and I read the function
> __del_qgroup_relation() in qgroup.c.
>
> This function checks whether dst is parent for src and store the result
> in variable named found. I think if the checks failed, the function
> needs to be failed or print warning message at least. Am I right? Or do
> you have other intentions?
>
User can specify a non-exist parent/child pair, in that case we don't
need to print error message, as -ENOENT is enough to inform the user.
Thanks,
Qu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Simple question for newbie developer about qgroup
2021-08-07 22:50 ` Qu Wenruo
@ 2021-08-08 11:56 ` Sidong Yang
0 siblings, 0 replies; 3+ messages in thread
From: Sidong Yang @ 2021-08-08 11:56 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs
On Sun, Aug 08, 2021 at 06:50:59AM +0800, Qu Wenruo wrote:
>
>
> On 2021/8/7 下午10:47, Sidong Yang wrote:
> > I read btrfs kernel source code about qgroup. I want to know about how
> > works adding or deleting qgroups. and I read the function
> > __del_qgroup_relation() in qgroup.c.
> >
> > This function checks whether dst is parent for src and store the result
> > in variable named found. I think if the checks failed, the function
> > needs to be failed or print warning message at least. Am I right? Or do
> > you have other intentions?
> >
>
> User can specify a non-exist parent/child pair, in that case we don't
> need to print error message, as -ENOENT is enough to inform the user.
Hi, Qu.
Thanks for informing me. Now I continue to read the code.
Thanks,
Sidong
>
> Thanks,
> Qu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-08 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-07 14:47 Simple question for newbie developer about qgroup Sidong Yang
2021-08-07 22:50 ` Qu Wenruo
2021-08-08 11:56 ` Sidong Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).