Re: [PATCH] btrfs: reflink: Assure length != 0 in btrfs_extent_same()

[Sidong Yang <realwakka@gmail.com>]

On Thu, Aug 19, 2021 at 08:12:49PM +0200, David Sterba wrote:
> On Thu, Aug 19, 2021 at 03:32:16PM +0000, Sidong Yang wrote:
> > On Thu, Aug 19, 2021 at 11:04:58AM +0300, Nikolay Borisov wrote:
> > > 
> > > 
> > > On 18.08.21 г. 19:08, Sidong Yang wrote:
> > > > btrfs_extent_same() cannot be called with zero length. Because when
> > > > length is zero, it would be filtered by condition in
> > > > btrfs_remap_file_range(). But if this function is used in other case in
> > > > future, it can make ret as uninitialized.
> > > > 
> > > > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > > 
> > > This is not sufficient, with the assert compiled out the error would
> > > still be in place. It seem that it is sufficient to initialize ret to
> > > some non-arbitrary value i.e -EINVAL ?
> > 
> > I agree. It's better way to assign intial value than adding assert. If
> > there is code that initialize ret, It seems that assert is no need for
> > this.
> 
> Patch with assert removed, please send the one initializing the return
> value, thanks.

Sure, I'll write it in v2.

Thanks,
Sidong