Re: [PATCH v2 4/4] btrfs: subpage: pack all subpage bitmaps into a larger bitmap

[David Sterba <dave@jikos.cz>]

On Tue, Aug 24, 2021 at 07:16:49AM +0800, Qu Wenruo wrote:
> >>   	spin_lock_irqsave(&subpage->lock, flags);
> >> -	subpage->uptodate_bitmap |= tmp;
> >> -	if (subpage->uptodate_bitmap == U16_MAX)
> >> +	bitmap_set(subpage->bitmaps, start_bit,
> >> +		   len >> fs_info->sectorsize_bits);
> >
> > All the bitmap_* calls like this and the parameter fit one line.
> >
> But that's over 80 chars.
> 
> I understand now our standard no longer requires 80 chars as hard limit,
> but isn't it seill recommended to keep inside the 80 chars limit?

If a slight overflow does not harm readability, like if word
'sectorsize' crosses 80 chars by like 4  I take it as reasonable and
join the lines if I see it. The 80 char limit is still there, because
merging patches sometimes requires 3 files next to each other so that is
really helpful.

As a visual clue where's the 80 boundary I have the following in .vimrc

let &colorcolumn="81,91,101,+0"

the +0 is for textwidth setting.