From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: remove the failing device argument from btrfs_check_rw_degradable()
Date: Thu, 9 Sep 2021 16:19:10 +0200 [thread overview]
Message-ID: <20210909141910.GY15306@suse.cz> (raw)
In-Reply-To: <b590dde5-05be-7957-636e-29c8253da147@oracle.com>
On Wed, Sep 08, 2021 at 10:25:52PM +0800, Anand Jain wrote:
> On 08/09/2021 00:05, David Sterba wrote:
> > On Tue, Sep 07, 2021 at 04:15:50PM +0100, fdmanana@kernel.org wrote:
> >> From: Filipe Manana <fdmanana@suse.com>
> >>
> >> Currently all callers of btrfs_check_rw_degradable() pass a NULL value for
> >> its 'failing_dev' argument, therefore making it useless. So just remove
> >> that argument.
> >
> > Anand, did you have plans with using the argument? It's been NULL since
> > the initial patch
> >
> > https://lore.kernel.org/linux-btrfs/00433e34-a56e-3898-80b9-32a304fe32e2@gmx.com/t/#u
> >
> > as commit 6528b99d3d20 ("btrfs: factor btrfs_check_rw_degradable() to
> > check given device") and it was not part of a series.
>
> I have a local patch which is V9 of this [1] using the 2nd argument of
> btrfs_check_rw_degradable(). Essentially to check if the mounted fs
> should fail or can continue to write when a disk fails.
>
> [1]
> btrfs: introduce device dynamic state transition to failed
>
> https://patchwork.kernel.org/project/linux-btrfs/patch/20171003155920.24925-2-anand.jain@oracle.com/
>
> We need further discussions on this design. I think.
Yeah this does not look like a simple feature. I think we can remove the
parameter for now and add back eventually.
prev parent reply other threads:[~2021-09-09 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 9:09 [PATCH] btrfs: fix mount failure due to past and transient device flush error fdmanana
2021-09-07 11:26 ` David Sterba
2021-09-07 15:15 ` Filipe Manana
2021-09-07 15:15 ` [PATCH 0/2] btrfs: fix mount/remount failure due to past device flush errors fdmanana
2021-09-07 15:15 ` [PATCH 1/2] btrfs: fix mount failure due to past and transient device flush error fdmanana
2021-09-08 14:19 ` Anand Jain
2021-09-08 14:26 ` Filipe Manana
2021-09-08 16:30 ` David Sterba
2021-09-08 17:32 ` Filipe Manana
2021-09-08 18:05 ` [PATCH v3] " fdmanana
2021-09-09 15:43 ` David Sterba
2021-09-07 15:15 ` [PATCH 2/2] btrfs: remove the failing device argument from btrfs_check_rw_degradable() fdmanana
2021-09-07 16:05 ` David Sterba
2021-09-08 14:25 ` Anand Jain
2021-09-09 14:19 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909141910.GY15306@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox