From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/3] btrfs: btrfs_bio and btrfs_io_bio rename
Date: Wed, 15 Sep 2021 15:17:15 +0800 [thread overview]
Message-ID: <20210915071718.59418-1-wqu@suse.com> (raw)
The branch can be fetched from github, and is the preferred way to grab
the code, as this patchset changed quite a lot of code.
https://github.com/adam900710/linux/tree/chunk_refactor
There are two structure, btrfs_io_bio and btrfs_bio, which have very
similar names but completely different meanings.
Btrfs_io_bio mostly works at logical bytenr layer (its
bio->bi_iter.bi_sector points to btrfs logical bytenr), and just
contains extra info like csum and mirror_num.
And btrfs_io_bio is in fact the most utilized bio, as all data/metadata
IO is using btrfs_io_bio.
While btrfs_bio is completely a helper structure for mirrored IO
submission (utilized by SINGLE/DUP/RAID1/RAID10), and contains RAID56
maps for RAID56 (it doesn't utilize this structure for IO submission
tracking).
Such naming is completely anti-human.
So this patchset will do the following renaming:
- btrfs_bio -> btrfs_io_context
Since it's not really used by all bios (only mirrored profiles utilize
it), and it contains extra info for RAID56, it's not proper to name it
with _bio suffix.
Later we can integrate btrfs_io_context pointer into the new
btrfs_bio.
- btrfs_io_bio -> btrfs_logical_bio
It is intentional not to reuse "btrfs_bio", which could cause
confusion for later backport.
Changelog:
v2:
- Rename btrfs_bio to btrfs_io_context (bioc)
- Rename btrfs_io_bio to btrfs_bio
Both suggested by Nikolay
v3:
- Fixes whiespace problems
Caused by "dwi" vim commands
- Update several modified comments
- Rename btrfs_io_bio to btrfs_logical_bio
To avoid backport confusion.
Qu Wenruo (3):
btrfs: rename btrfs_bio to btrfs_io_context
btrfs: remove btrfs_bio_alloc() helper
btrfs: rename struct btrfs_io_bio to btrfs_logical_bio
fs/btrfs/check-integrity.c | 4 +-
fs/btrfs/compression.c | 20 +--
fs/btrfs/ctree.h | 6 +-
fs/btrfs/disk-io.c | 2 +-
fs/btrfs/disk-io.h | 2 +-
fs/btrfs/extent-tree.c | 19 ++-
fs/btrfs/extent_io.c | 116 ++++++++--------
fs/btrfs/extent_io.h | 8 +-
fs/btrfs/extent_map.c | 4 +-
fs/btrfs/file-item.c | 12 +-
fs/btrfs/inode.c | 50 +++----
fs/btrfs/raid56.c | 135 +++++++++---------
fs/btrfs/raid56.h | 8 +-
fs/btrfs/reada.c | 26 ++--
fs/btrfs/scrub.c | 130 +++++++++---------
fs/btrfs/volumes.c | 272 ++++++++++++++++++-------------------
fs/btrfs/volumes.h | 63 +++++----
fs/btrfs/zoned.c | 16 +--
18 files changed, 455 insertions(+), 438 deletions(-)
--
2.33.0
next reply other threads:[~2021-09-15 7:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 7:17 Qu Wenruo [this message]
2021-09-15 7:17 ` [PATCH v3 1/3] btrfs: rename btrfs_bio to btrfs_io_context Qu Wenruo
2021-09-17 11:19 ` David Sterba
2021-09-17 11:24 ` Qu Wenruo
2021-09-17 11:27 ` Qu Wenruo
2021-09-17 11:33 ` David Sterba
2021-09-15 7:17 ` [PATCH v3 2/3] btrfs: remove btrfs_bio_alloc() helper Qu Wenruo
2021-09-17 12:27 ` Nikolay Borisov
2021-09-17 12:33 ` Qu Wenruo
2021-09-17 12:34 ` Nikolay Borisov
2021-09-17 12:43 ` David Sterba
2021-09-17 12:49 ` Nikolay Borisov
2021-09-20 10:33 ` Qu Wenruo
2021-09-20 12:41 ` David Sterba
2021-09-20 12:42 ` Qu Wenruo
2021-09-23 5:57 ` Qu Wenruo
2021-09-15 7:17 ` [PATCH v3 3/3] btrfs: rename struct btrfs_io_bio to btrfs_logical_bio Qu Wenruo
2021-09-17 11:39 ` David Sterba
2021-09-20 7:04 ` Nikolay Borisov
2021-09-20 12:23 ` David Sterba
2021-09-20 13:10 ` David Sterba
2021-09-17 11:39 ` [PATCH v3 0/3] btrfs: btrfs_bio and btrfs_io_bio rename David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915071718.59418-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox