From: David Sterba <dsterba@suse.cz>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/5] btrfs-progs: property: ro->rw and received_uuid
Date: Mon, 4 Oct 2021 17:22:29 +0200 [thread overview]
Message-ID: <20211004152229.GA9286@twin.jikos.cz> (raw)
In-Reply-To: <cf04c434-c95d-eb88-770d-ca564a97dcb3@gmail.com>
On Sat, Oct 02, 2021 at 10:05:19AM +0300, Andrei Borzenkov wrote:
> On 01.10.2021 18:29, David Sterba wrote:
> > Implement safety check when a read-only subvolume is getting switched
> > to read-write and there's received_uuid set.
> >
> > This prevents accidental breakage of incremental send usecase but allows
> > user to do the rw change anyway but resets the received_uuid in that
> > case.
> >
> > As this is implemented entirely in userspace, it's racy and using the
> > raw ioctl won't prevent it nor reset the received_uuid.
> >
>
> Is it feasible to add "force" flag to ioctl itself?
Yeah that's possible but affects the ioctl semantics, so that's a bit
more tricky than the userspace side. It would solve the atomicity
problem in this patchset.
next prev parent reply other threads:[~2021-10-04 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 15:28 [PATCH 0/5] Subvolume ro/rw and received_uuid David Sterba
2021-10-01 15:28 ` [PATCH 1/5] btrfs-progs: subvol show: print send and receive generation and timestamp David Sterba
2021-10-01 15:28 ` [PATCH 2/5] btrfs-progs: dump-tree: print complete root_item David Sterba
2021-10-01 15:29 ` [PATCH 3/5] btrfs-progs: props: add force parameter to set David Sterba
2021-10-01 15:29 ` [PATCH 4/5] btrfs-progs: property: ro->rw and received_uuid David Sterba
2021-10-02 7:05 ` Andrei Borzenkov
2021-10-04 15:22 ` David Sterba [this message]
2021-10-04 10:10 ` Nikolay Borisov
2021-10-04 15:21 ` David Sterba
2021-10-01 15:29 ` [PATCH 5/5] btrfs-progs: tests: subvolume ro->rw switch " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004152229.GA9286@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=arvidjaar@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox