From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 3/3] btrfs-progs: mfks-tests: make sure mkfs.btrfs cleans up temporary chunks
Date: Mon, 11 Oct 2021 17:43:00 +0800 [thread overview]
Message-ID: <20211011094300.97504-4-wqu@suse.com> (raw)
In-Reply-To: <20211011094300.97504-1-wqu@suse.com>
Since current "btrfs filesystem df" command will warn if there are
multiple profiles of the same type, it's a good way to detect left-over
temporary chunks.
This patch will enhance the existing mkfs-tests/001-basic-profiles test
case to also check for the warning messages, to make sure mkfs.btrfs has
properly cleaned up all temporary chunks.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/mkfs-tests/001-basic-profiles/test.sh | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/mkfs-tests/001-basic-profiles/test.sh b/tests/mkfs-tests/001-basic-profiles/test.sh
index b3ba50d71ddc..e44f9344bc6f 100755
--- a/tests/mkfs-tests/001-basic-profiles/test.sh
+++ b/tests/mkfs-tests/001-basic-profiles/test.sh
@@ -11,11 +11,17 @@ setup_root_helper
test_get_info()
{
+ tmp_out=$(mktemp --tmpdir btrfs-progs-mkfs-tests-get-info.XXXXXX)
run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$dev1"
run_check $SUDO_HELPER "$TOP/btrfs" check "$dev1"
run_check $SUDO_HELPER mount "$dev1" "$TEST_MNT"
- run_check "$TOP/btrfs" filesystem df "$TEST_MNT"
- run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
+ run_check_stdout "$TOP/btrfs" filesystem df "$TEST_MNT" > "$tmp_out"
+ if grep -q "Multiple block group profiles detected" "$tmp_out"; then
+ rm -- "$tmp_out"
+ _fail "temporary chunks are not properly cleaned up"
+ fi
+ rm -- "$tmp_out"
+ run_check$SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"
run_check $SUDO_HELPER umount "$TEST_MNT"
}
--
2.33.0
next prev parent reply other threads:[~2021-10-11 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 9:42 [PATCH 0/3] btrfs-progs: mkfs: make sure we can clean up all temporary chunks Qu Wenruo
2021-10-11 9:42 ` [PATCH 1/3] btrfs-progs: rename @data parameter to @profile in extent allocation path Qu Wenruo
2021-10-11 9:42 ` [PATCH 2/3] btrfs-progs: mkfs: recow all tree blocks properly Qu Wenruo
2021-10-11 9:43 ` Qu Wenruo [this message]
2021-10-11 10:29 ` [PATCH 3/3] btrfs-progs: mfks-tests: make sure mkfs.btrfs cleans up temporary chunks David Sterba
2021-10-11 10:40 ` David Sterba
2021-10-11 11:12 ` Qu Wenruo
2021-10-11 10:31 ` [PATCH 0/3] btrfs-progs: mkfs: make sure we can clean up all " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011094300.97504-4-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox