From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-btrfs-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 06388C433F5
	for <linux-btrfs@archiver.kernel.org>; Thu, 14 Oct 2021 15:53:46 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id CD2E361040
	for <linux-btrfs@archiver.kernel.org>; Thu, 14 Oct 2021 15:53:45 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232110AbhJNPzt (ORCPT <rfc822;linux-btrfs@archiver.kernel.org>);
        Thu, 14 Oct 2021 11:55:49 -0400
Received: from verein.lst.de ([213.95.11.211]:50714 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230109AbhJNPzs (ORCPT <rfc822;linux-btrfs@vger.kernel.org>);
        Thu, 14 Oct 2021 11:55:48 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 78AD568B05; Thu, 14 Oct 2021 17:53:41 +0200 (CEST)
Date:   Thu, 14 Oct 2021 17:53:41 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Josef Bacik <josef@toxicpanda.com>
Cc:     Christoph Hellwig <hch@lst.de>, linux-btrfs@vger.kernel.org,
        kernel-team@fb.com
Subject: Re: [PATCH] btrfs: update device path inode time instead of
 bd_inode
Message-ID: <20211014155341.GA32052@lst.de>
References: <00b8cf32502e30403b9849a73e62f4ad5175fded.1634224611.git.josef@toxicpanda.com> <20211014153347.GA30555@lst.de> <YWhRr123vMRtiHF4@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWhRr123vMRtiHF4@localhost.localdomain>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-btrfs.vger.kernel.org>
X-Mailing-List: linux-btrfs@vger.kernel.org

On Thu, Oct 14, 2021 at 11:50:07AM -0400, Josef Bacik wrote:
> On Thu, Oct 14, 2021 at 05:33:47PM +0200, Christoph Hellwig wrote:
> > On Thu, Oct 14, 2021 at 11:17:08AM -0400, Josef Bacik wrote:
> > > +	now = current_time(d_inode(path.dentry));
> > > +	generic_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME);
> > 
> > This is still broken as it won't call into ->update_time.
> > generic_update_time is a helper/default for ->update_time, not something
> > for an external caller.
> 
> Then we probably need to fix all the people currently calling it.

All other callers are from update_time / ->update_time.

> In the
> meantime I'll add a helper to use the thing that calls ->update_time instead.
> Thanks,

Looking at this a bit more I think the right fix is to simply revert the
offending commit.  The lockdep complains was due to changes issues in the
loop driver and has been fixed in the loop driver in the meantime.