public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs: cleanup on btrfs_super_block definition
Date: Tue, 19 Oct 2021 19:29:23 +0800	[thread overview]
Message-ID: <20211019112925.71920-1-wqu@suse.com> (raw)

This patch is to enhance the definition of btrfs_super_block by:

- Unify sizeof(struct btrfs_super_block) and BTRFS_SUPER_INFO_SIZE
  In kernel, it's just 3 location allocating BTRFS_SUPER_INFO_SIZE
  (one of them is for selftest), so such change is not doing much
  difference.
  But for btrfs-progs, it would remove call sites like:

        char tmp[BTRFS_SUPER_INFO_SIZE];
        struct btrfs_super_block *buf = (struct btrfs_super_block *)tmp;
 
- Move btrfs_super_block definition to uapi/linux/btrfs_tree.h.
  Due to BTRFS_IOC_TREE_SEARCH ioctl, we're almost exposing all on-disk
  formats to the user space.
  Thus it's almost a perfect location to contain all on-disk schema.

Qu Wenruo (2):
  btrfs: make sizeof(struct btrfs_super_block) to match
    BTRFS_SUPER_INFO_SIZE
  btrfs: move btrfs_super_block to uapi/linux/btrfs_tree.h

 fs/btrfs/ctree.h                | 136 --------------------------------
 fs/btrfs/super.c                |   2 +
 include/uapi/linux/btrfs_tree.h | 135 +++++++++++++++++++++++++++++++
 3 files changed, 137 insertions(+), 136 deletions(-)

-- 
2.33.0


             reply	other threads:[~2021-10-19 11:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 11:29 Qu Wenruo [this message]
2021-10-19 11:29 ` [PATCH 1/2] btrfs: make sizeof(struct btrfs_super_block) to match BTRFS_SUPER_INFO_SIZE Qu Wenruo
2021-10-19 15:46   ` David Sterba
2021-10-19 11:29 ` [PATCH 2/2] btrfs: move btrfs_super_block to uapi/linux/btrfs_tree.h Qu Wenruo
2021-10-19 16:10   ` David Sterba
2021-10-20  0:19     ` Qu Wenruo
2021-10-20 17:13       ` David Sterba
2021-10-20 23:18         ` Qu Wenruo
2021-11-07 23:24   ` kernel test robot
2021-10-19 14:08 ` [PATCH 0/2] btrfs: cleanup on btrfs_super_block definition Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019112925.71920-1-wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox