Re: [PATCH v2 1/2] fs: export an inode_update_time helper

[David Sterba <dsterba@suse.cz>]

On Mon, Oct 25, 2021 at 09:45:09AM +0200, Christoph Hellwig wrote:
> On Thu, Oct 21, 2021 at 06:38:17PM +0200, David Sterba wrote:
> > On Thu, Oct 14, 2021 at 01:11:00PM -0400, Josef Bacik wrote:
> > > If you already have an inode and need to update the time on the inode
> > > there is no way to do this properly.  Export this helper to allow file
> > > systems to update time on the inode so the appropriate handler is
> > > called, either ->update_time or generic_update_time.
> > > 
> > > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> > 
> > I'd like to get ack from Christoph, though it's a simple change it's
> > still in another subsystem.
> 
> Not a big fan, but compared to the other options it seems like the
> least bad option.

Thanks, given that it fixes the time update problem and is otherwise
quite unintrusive it should be ok.

> That being said I'm not the VFS maintainer anyway.

Well yeah, but you reviewed or was involved in some other similar
changes, so I take it as a confirmation that we're not abusing some VFS
internal.  But I'm adding Al Viro to CC anyway.