From: kernel test robot <lkp@intel.com>
To: wangyugui <wangyugui@e16-tech.com>,
linux-btrfs@vger.kernel.org, l@damenly.su
Cc: kbuild-all@lists.01.org, wangyugui <wangyugui@e16-tech.com>
Subject: Re: [PATCH] btrfs: fix CHECK_INTEGRITY warning when !QUEUE_FLAG_WC
Date: Tue, 2 Nov 2021 13:32:21 +0800 [thread overview]
Message-ID: <202111021339.P8Ewzvel-lkp@intel.com> (raw)
In-Reply-To: <20211022082637.50880-1-wangyugui@e16-tech.com>
[-- Attachment #1: Type: text/plain, Size: 4079 bytes --]
Hi wangyugui,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on v5.15 next-20211101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/wangyugui/btrfs-fix-CHECK_INTEGRITY-warning-when-QUEUE_FLAG_WC/20211022-162718
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/ced40ee717d7e4e8a131b61855a86f0d55aaf817
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review wangyugui/btrfs-fix-CHECK_INTEGRITY-warning-when-QUEUE_FLAG_WC/20211022-162718
git checkout ced40ee717d7e4e8a131b61855a86f0d55aaf817
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/btrfs/disk-io.c: In function 'write_dev_flush':
>> fs/btrfs/disk-io.c:3981:24: error: unused variable 'q' [-Werror=unused-variable]
3981 | struct request_queue *q = bdev_get_queue(device->bdev);
| ^
cc1: all warnings being treated as errors
vim +/q +3981 fs/btrfs/disk-io.c
387125fc722a8e Chris Mason 2011-11-18 3974
387125fc722a8e Chris Mason 2011-11-18 3975 /*
4fc6441aac7589 Anand Jain 2017-06-13 3976 * Submit a flush request to the device if it supports it. Error handling is
4fc6441aac7589 Anand Jain 2017-06-13 3977 * done in the waiting counterpart.
387125fc722a8e Chris Mason 2011-11-18 3978 */
4fc6441aac7589 Anand Jain 2017-06-13 3979 static void write_dev_flush(struct btrfs_device *device)
387125fc722a8e Chris Mason 2011-11-18 3980 {
c2a9c7ab475bc3 Anand Jain 2017-04-06 @3981 struct request_queue *q = bdev_get_queue(device->bdev);
e0ae999414238a David Sterba 2017-06-06 3982 struct bio *bio = device->flush_bio;
387125fc722a8e Chris Mason 2011-11-18 3983
ced40ee717d7e4 wangyugui 2021-10-22 3984 #ifndef CONFIG_BTRFS_FS_CHECK_INTEGRITY
ced40ee717d7e4 wangyugui 2021-10-22 3985 /*
ced40ee717d7e4 wangyugui 2021-10-22 3986 * submit_bio(REQ_SYNC | REQ_PREFLUSH) can be skipped when !QUEUE_FLAG_WC.
ced40ee717d7e4 wangyugui 2021-10-22 3987 * but btrfsic_submit_bio() != submit_bio() when CONFIG_BTRFS_FS_CHECK_INTEGRITY
ced40ee717d7e4 wangyugui 2021-10-22 3988 */
c2a9c7ab475bc3 Anand Jain 2017-04-06 3989 if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags))
4fc6441aac7589 Anand Jain 2017-06-13 3990 return;
ced40ee717d7e4 wangyugui 2021-10-22 3991 #endif
387125fc722a8e Chris Mason 2011-11-18 3992
e0ae999414238a David Sterba 2017-06-06 3993 bio_reset(bio);
387125fc722a8e Chris Mason 2011-11-18 3994 bio->bi_end_io = btrfs_end_empty_barrier;
74d46992e0d9de Christoph Hellwig 2017-08-23 3995 bio_set_dev(bio, device->bdev);
8d91012528b3c9 Jan Kara 2017-05-02 3996 bio->bi_opf = REQ_OP_WRITE | REQ_SYNC | REQ_PREFLUSH;
387125fc722a8e Chris Mason 2011-11-18 3997 init_completion(&device->flush_wait);
387125fc722a8e Chris Mason 2011-11-18 3998 bio->bi_private = &device->flush_wait;
387125fc722a8e Chris Mason 2011-11-18 3999
43a0111103af2d Lu Fengqi 2017-08-18 4000 btrfsic_submit_bio(bio);
1c3063b6dbfa03 Anand Jain 2017-12-04 4001 set_bit(BTRFS_DEV_STATE_FLUSH_SENT, &device->dev_state);
387125fc722a8e Chris Mason 2011-11-18 4002 }
387125fc722a8e Chris Mason 2011-11-18 4003
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66036 bytes --]
next prev parent reply other threads:[~2021-11-02 5:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 7:29 fstest/btrfs/220 tigger a check-integrity warning Wang Yugui
2021-10-15 5:38 ` Wang Yugui
2021-10-21 6:13 ` Su Yue
2021-10-22 4:49 ` Wang Yugui
2021-10-22 5:07 ` Wang Yugui
2021-10-22 8:26 ` [PATCH] btrfs: fix CHECK_INTEGRITY warning when !QUEUE_FLAG_WC wangyugui
2021-10-22 14:42 ` Filipe Manana
2021-11-02 5:32 ` kernel test robot [this message]
2021-11-02 5:49 ` Wang Yugui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111021339.P8Ewzvel-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=l@damenly.su \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).