Re: [PATCH] btrfs-progs: Make "btrfs filesystem df" command to show upper case profile

David Sterba
2021-11-02T16:17:05Z

On Tue, Nov 02, 2021 at 08:23:45PM +0800, Wang Yugui wrote:
> Hi,
>
> before Commit dad03fac3bb8 ("btrfs-progs: switch btrfs_group_profile_str to use
> raid table") , 'single' is lower case. others, such as RAID1 , are
> upper case.
>
> I don't know whether it is necessary to keep 'single' as lower case.

Looks like it's better to keep it as it was, which would mean lowercase
single and uppercase the rest, with some additional conditions.

> maybe we can change the array value directly?
> ./kernel-shared/volumes.c:62: [BTRFS_RAID_RAID1C3] = {
> ./kernel-shared/volumes.c:71: .raid_name = "raid1c3",

Either making the table name the one we want to print with the right
case, or add another that is same as kernel has and another for
printing.