From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>,
David Sterba <dsterba@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v2 1/4] btrfs: zoned: encapsulate inode locking for zoned relocation
Date: Wed, 8 Dec 2021 13:05:01 +0100 [thread overview]
Message-ID: <20211208120501.GI28560@twin.jikos.cz> (raw)
In-Reply-To: <PH0PR04MB7416360B934D51D55BB4818E9B6F9@PH0PR04MB7416.namprd04.prod.outlook.com>
On Wed, Dec 08, 2021 at 09:06:14AM +0000, Johannes Thumshirn wrote:
> On 07/12/2021 20:08, David Sterba wrote:
> > All internal API should use struct btrfs_inode, applied with the
> > following diff:
>
> Ah ok, good to know. I wanted to have a bit less pointer casing
> with using 'struct inode'. Anyways I don't mind.
Now it's a mix of both and needs more works to unify but at least new
code should be done the right way. The pointer chasing will go
eventually and I don't think it has a measurable impact.
next prev parent reply other threads:[~2021-12-08 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 14:28 [PATCH v2 0/4] btrfs: first batch of zoned cleanups Johannes Thumshirn
2021-12-07 14:28 ` [PATCH v2 1/4] btrfs: zoned: encapsulate inode locking for zoned relocation Johannes Thumshirn
2021-12-07 19:08 ` David Sterba
2021-12-08 9:06 ` Johannes Thumshirn
2021-12-08 12:05 ` David Sterba [this message]
2021-12-07 14:28 ` [PATCH v2 2/4] btrfs: zoned: simplify btrfs_check_meta_write_pointer Johannes Thumshirn
2021-12-07 14:28 ` [PATCH v2 3/4] btrfs: zoned: sink zone check into btrfs_repair_one_zone Johannes Thumshirn
2021-12-07 14:28 ` [PATCH v2 4/4] btrfs: zoned: it's pointless to check for REQ_OP_ZONE_APPEND and btrfs_is_zoned Johannes Thumshirn
2021-12-07 19:12 ` [PATCH v2 0/4] btrfs: first batch of zoned cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208120501.GI28560@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox