Re: [PATCH v2] btrfs/255: add test for quota disable in parallel with balance

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Jan 18, 2022 / 14:46, Filipe Manana wrote:
> On Tue, Jan 18, 2022 at 02:57:21PM +0900, Shin'ichiro Kawasaki wrote:

(snip)

> > +# Run btrfs balance and quota enable/disable in parallel
> > +_btrfs_stress_balance $SCRATCH_MNT >> $seqres.full &
> > +balance_pid=$!
> > +echo $balance_pid >> $seqres.full
> > +for ((i = 0; i < 20; i++)); do
> > +	$BTRFS_UTIL_PROG quota enable $SCRATCH_MNT
> > +	$BTRFS_UTIL_PROG quota disable $SCRATCH_MNT
> > +done
> > +kill $balance_pid &> /dev/null
> 
> You need to wait for the balance pid to exit before terminating the test,
> otherwise the test will fail often when the fstests framework is trying
> to unmount the scratch device (with an -EBUSY returned from umount).
> 
> And please do like in other tests that use _btrfs_stress_balance():
> 
> 	kill $balance_pid
> 	wait
> 	# wait for the balance operation to finish
> 	while ps aux | grep "balance start" | grep -qv grep; do
> 		sleep 1
> 	done
> 
> Like in btrfs/060 for example.
> 
> Other than that, it looks fine, thanks.

Thanks. Will update the patch as you commented and send out v3.

-- 
Best Regards,
Shin'ichiro Kawasaki