From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: fix log tree cleanup after a transaction abort
Date: Tue, 25 Jan 2022 17:58:21 +0100 [thread overview]
Message-ID: <20220125165821.GT14046@twin.jikos.cz> (raw)
In-Reply-To: <3aae7c6728257c7ce2279d6660ee2797e5e34bbd.1641300250.git.fdmanana@suse.com>
On Tue, Jan 04, 2022 at 12:54:15PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
>
> V3: Renamed subject (was "btrfs: fix reserved space leak on log tree nodes after transaction abort").
> Reworked the patch to take into account that after writeback is triggered through log syncing,
> the range of the extent buffers is removed from the log dirty pages io tree. That was making
> the mentioned test cases still fail often (just a bit less often however).
> Also take into account that if fail during the cleanup, we stopped iterating over the tree
> and leaving some extent buffers not being cleaned up - this was actually often triggered by
> generic/648.
For the recrod, there's a report
https://lore.kernel.org/all/YeVcOXAsCcA7ijoX@debian9.Home/ that this
patch makes performance worse and that there will be a different patch.
I've removed it from misc-next now.
prev parent reply other threads:[~2022-01-25 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 12:20 [PATCH] btrfs: fix reserved space leak on log tree nodes after transaction abort fdmanana
2021-12-17 12:35 ` [PATCH v2] " fdmanana
2021-12-17 14:02 ` Wang Yugui
2021-12-17 14:54 ` Filipe Manana
2021-12-18 11:26 ` Filipe Manana
2022-01-03 18:00 ` [PATCH] " Josef Bacik
2022-01-03 18:39 ` Filipe Manana
2022-01-04 12:54 ` [PATCH v3] btrfs: fix log tree cleanup after a " fdmanana
2022-01-06 14:53 ` David Sterba
2022-01-25 16:58 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125165821.GT14046@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox