Re: [PATCH] btrfs: qgroup: replace modifing qgroup_flags to bitops

[kernel test robot <lkp@intel.com>]

Hi Sidong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.17-rc2]
[cannot apply to kdave/for-next next-20220131]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sidong-Yang/btrfs-qgroup-replace-modifing-qgroup_flags-to-bitops/20220201-205452
base:    26291c54e111ff6ba87a164d85d4a4e134b7315c
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220201/202202012156.wyQPJZyD-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ba6f4f3d431a14034f4e4da2b8f342fe17ec78bf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sidong-Yang/btrfs-qgroup-replace-modifing-qgroup_flags-to-bitops/20220201-205452
        git checkout ba6f4f3d431a14034f4e4da2b8f342fe17ec78bf
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/btrfs/qgroup.c: In function 'qgroup_rescan_init':
>> fs/btrfs/qgroup.c:3375:70: warning: passing argument 2 of 'test_bit' makes pointer from integer without a cast [-Wint-conversion]
    3375 |                 if (test_bit(BTRFS_QGROUP_STATUS_FLAG_RESCAN, fs_info->qgroup_flags)) {
         |                                                               ~~~~~~~^~~~~~~~~~~~~~
         |                                                                      |
         |                                                                      u64 {aka long long unsigned int}
   In file included from include/linux/bitops.h:33,
                    from include/linux/thread_info.h:27,
                    from include/asm-generic/current.h:5,
                    from ./arch/alpha/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from fs/btrfs/qgroup.c:6:
   arch/alpha/include/asm/bitops.h:287:40: note: expected 'const volatile void *' but argument is of type 'u64' {aka 'long long unsigned int'}
     287 | test_bit(int nr, const volatile void * addr)
         |                  ~~~~~~~~~~~~~~~~~~~~~~^~~~


vim +/test_bit +3375 fs/btrfs/qgroup.c

  3345	
  3346	/*
  3347	 * Checks that (a) no rescan is running and (b) quota is enabled. Allocates all
  3348	 * memory required for the rescan context.
  3349	 */
  3350	static int
  3351	qgroup_rescan_init(struct btrfs_fs_info *fs_info, u64 progress_objectid,
  3352			   int init_flags)
  3353	{
  3354		int ret = 0;
  3355	
  3356		if (!init_flags) {
  3357			/* we're resuming qgroup rescan at mount time */
  3358			if (!test_bit(BTRFS_QGROUP_STATUS_FLAG_RESCAN, &fs_info->qgroup_flags)) {
  3359				btrfs_warn(fs_info,
  3360				"qgroup rescan init failed, qgroup rescan is not queued");
  3361				ret = -EINVAL;
  3362			} else if (!test_bit(BTRFS_QGROUP_STATUS_FLAG_ON, &fs_info->qgroup_flags)) {
  3363				btrfs_warn(fs_info,
  3364				"qgroup rescan init failed, qgroup is not enabled");
  3365				ret = -EINVAL;
  3366			}
  3367	
  3368			if (ret)
  3369				return ret;
  3370		}
  3371	
  3372		mutex_lock(&fs_info->qgroup_rescan_lock);
  3373	
  3374		if (init_flags) {
> 3375			if (test_bit(BTRFS_QGROUP_STATUS_FLAG_RESCAN, fs_info->qgroup_flags)) {
  3376				btrfs_warn(fs_info,
  3377					   "qgroup rescan is already in progress");
  3378				ret = -EINPROGRESS;
  3379			} else if (!test_bit(BTRFS_QGROUP_STATUS_FLAG_ON, &fs_info->qgroup_flags)) {
  3380				btrfs_warn(fs_info,
  3381				"qgroup rescan init failed, qgroup is not enabled");
  3382				ret = -EINVAL;
  3383			}
  3384	
  3385			if (ret) {
  3386				mutex_unlock(&fs_info->qgroup_rescan_lock);
  3387				return ret;
  3388			}
  3389			set_bit(BTRFS_QGROUP_STATUS_FLAG_RESCAN, &fs_info->qgroup_flags);
  3390		}
  3391	
  3392		memset(&fs_info->qgroup_rescan_progress, 0,
  3393			sizeof(fs_info->qgroup_rescan_progress));
  3394		fs_info->qgroup_rescan_progress.objectid = progress_objectid;
  3395		init_completion(&fs_info->qgroup_rescan_completion);
  3396		mutex_unlock(&fs_info->qgroup_rescan_lock);
  3397	
  3398		btrfs_init_work(&fs_info->qgroup_rescan_work,
  3399				btrfs_qgroup_rescan_worker, NULL, NULL);
  3400		return 0;
  3401	}
  3402	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org