From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs-progs: sanity check global roots key.offset
Date: Wed, 9 Feb 2022 16:25:28 +0100 [thread overview]
Message-ID: <20220209152528.GL12643@twin.jikos.cz> (raw)
In-Reply-To: <a5b18eac38f561d7f671454b0601f5173b5cc2cd.1644348533.git.josef@toxicpanda.com>
On Tue, Feb 08, 2022 at 02:30:05PM -0500, Josef Bacik wrote:
> For !extent tree v2 we should validate the key.offset == 0, and for
> extent tree v2 we should validate that key.offset < nr_global_roots. If
> this fails we need to fail to load the global root so that the
> appropriate action is taken.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> Dave, this fixes GH issue https://github.com/kdave/btrfs-progs/issues/446, the
> problem was we weren't catching that nr_global_roots was incorrect and then
> segfaulting later. I think I sent this as part of a series, but it stands
> alone.
Thanks, I think I've merged all the prep stuff, in kernel and in progs
too, so I'll do another batch for 5.17.
prev parent reply other threads:[~2022-02-09 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 19:30 [PATCH] btrfs-progs: sanity check global roots key.offset Josef Bacik
2022-02-09 15:25 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209152528.GL12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox