Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Sidong Yang <realwakka@gmail.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: qgroup: Remove outdated TODO comments
Date: Sat, 12 Feb 2022 10:17:05 +0000	[thread overview]
Message-ID: <20220212101705.GB1181@realwakka> (raw)
In-Reply-To: <402c8a70-7589-4a29-6c1c-28e0b75e0716@gmx.com>

On Sat, Feb 12, 2022 at 08:13:29AM +0800, Qu Wenruo wrote:
> 
> 
> On 2022/2/11 21:48, Sidong Yang wrote:
> > These comments are too old and outdated. It seems that it doesn't help.
> > So we can remove those.
> > 
> > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > ---
> >   fs/btrfs/qgroup.c | 11 -----------
> >   1 file changed, 11 deletions(-)
> > 
> > diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> > index bfd45d52b1f5..db527c277901 100644
> > --- a/fs/btrfs/qgroup.c
> > +++ b/fs/btrfs/qgroup.c
> > @@ -25,17 +25,6 @@
> >   #include "sysfs.h"
> >   #include "tree-mod-log.h"
> > 
> > -/* TODO XXX FIXME
> > - *  - subvol delete -> delete when ref goes to 0? delete limits also?
> 
> This is still under concern AFAIK.
> 
> Currently if we delete a subvolume, its qgroup number will changed to 0
> but not removed.

This issue is in btrfs-progs github issue list (#366). It has detailed
description in there. So, I think it's okay to delete this.

Thanks,
Sidong
> 
> Thanks,
> Qu
> 
> > - *  - reorganize keys
> > - *  - compressed
> > - *  - sync
> > - *  - limit
> > - *  - caches for ulists
> > - *  - performance benchmarks
> > - *  - check all ioctl parameters
> > - */
> > -
> >   /*
> >    * Helpers to access qgroup reservation
> >    *

  reply	other threads:[~2022-02-12 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 13:48 [PATCH] btrfs: qgroup: Remove outdated TODO comments Sidong Yang
2022-02-11 16:34 ` David Sterba
2022-02-12  0:13 ` Qu Wenruo
2022-02-12 10:17   ` Sidong Yang [this message]
2022-02-12 10:26     ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220212101705.GB1181@realwakka \
    --to=realwakka@gmail.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox