Re: [PATCH] fstests: fix btrfs/255 to fail on deadlock

Eryu Guan
2022-03-20T15:33:44Z

On Wed, Feb 23, 2022 at 06:11:26PM +0100, David Sterba wrote:
> On Mon, Feb 21, 2022 at 01:07:35AM +0800, Eryu Guan wrote:
> > On Wed, Feb 16, 2022 at 11:05:35AM +0100, Gabriel Niebler wrote:
> > > In its current implementation, the test btrfs/255 would hang forever
> > > on any kernel w/o patch "btrfs: fix deadlock between quota disable
> > > and qgroup rescan worker", rather than failing, as it should.
> > > Fix this by introducing generous timeouts.
> > >
> > > Signed-off-by: Gabriel Niebler <gniebler@suse.com>
> >
> > If deadlock was already triggered, I don't think killing the userspace
> > program with timeout will help, as the kernel already deadlocked, and
> > filesystem and/or device can't be used by next test either.
> >
> > I think we should just exclude the test when running tests on unpatched
> > kernel.
>
> I don't see a way how to detect it at runtime, or do you mean to use the
> expunge files?

Yes, use expunge file and run fstests with './check -E <path_to_expunge_file>'

Thanks,
Eryu