From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: stable@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH for v5.15 2/2] btrfs: defrag: use the same cluster size for defrag ioctl and autodefrag
Date: Wed, 16 Feb 2022 13:37:59 +0100 [thread overview]
Message-ID: <20220216123759.GP12643@twin.jikos.cz> (raw)
In-Reply-To: <d2ce0079f3d2144876f019575858b392263089c4.1644994950.git.wqu@suse.com>
On Wed, Feb 16, 2022 at 03:09:08PM +0800, Qu Wenruo wrote:
> No upstream commit.
> Since the bug only exists between v5.11 and v5.15. In v5.16 btrfs
> reworked defrag and no longer has this bug.
I'm not sure this will work as a stable patch. A backport of an existing
upstream patch that is only adapted to older stable code base is fine
but what is the counterpart of this patch?
>
> [BUG]
> Since commit 7f458a3873ae ("btrfs: fix race when defragmenting leads to
> unnecessary IO") autodefrag no longer works with the following script:
The bug does no seem to be significant, autodefrag is basically a
heuristic so if it does not work perfectly in all cases it's still OK.
next prev parent reply other threads:[~2022-02-16 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 7:09 [PATCH for v5.15 0/2] Defrag fixes for v5.15 Qu Wenruo
2022-02-16 7:09 ` [PATCH for v5.15 1/2] btrfs: don't hold CPU for too long when defragging a file Qu Wenruo
2022-02-17 19:01 ` Greg KH
2022-02-17 19:41 ` Holger Hoffstätte
2022-02-17 19:48 ` Greg KH
2022-02-18 0:06 ` Qu Wenruo
2022-02-16 7:09 ` [PATCH for v5.15 2/2] btrfs: defrag: use the same cluster size for defrag ioctl and autodefrag Qu Wenruo
2022-02-16 12:37 ` David Sterba [this message]
2022-02-16 12:49 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216123759.GP12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox