From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: remove the cross file system checks from remap
Date: Wed, 16 Feb 2022 22:37:55 +0100 [thread overview]
Message-ID: <20220216213755.GR12643@twin.jikos.cz> (raw)
In-Reply-To: <ef6f142a8be5bb8a3d2ac2643cc01870038f11b9.1645041975.git.josef@toxicpanda.com>
On Wed, Feb 16, 2022 at 03:06:26PM -0500, Josef Bacik wrote:
> This is handled in the generic VFS helper, we do not need to duplicate
> this inside of btrfs.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/reflink.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/reflink.c b/fs/btrfs/reflink.c
> index a3930da4eb3f..4425030e09cb 100644
> --- a/fs/btrfs/reflink.c
> +++ b/fs/btrfs/reflink.c
> @@ -771,10 +771,6 @@ static int btrfs_remap_file_range_prep(struct file *file_in, loff_t pos_in,
>
> if (btrfs_root_readonly(root_out))
> return -EROFS;
> -
> - if (file_in->f_path.mnt != file_out->f_path.mnt ||
> - inode_in->i_sb != inode_out->i_sb)
> - return -EXDEV;
Should the super block check be at least an assert?
next prev parent reply other threads:[~2022-02-16 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 20:06 [PATCH] btrfs: remove the cross file system checks from remap Josef Bacik
2022-02-16 21:37 ` David Sterba [this message]
2022-02-18 13:15 ` Nikolay Borisov
2022-02-18 13:22 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216213755.GR12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox