From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH v3 1/2] btrfs: defrag: bring back the old file extent search behavior
Date: Mon, 21 Feb 2022 18:22:23 +0100 [thread overview]
Message-ID: <20220221172223.GK12643@twin.jikos.cz> (raw)
In-Reply-To: <c372f57e-2ffc-6d6d-b656-5331464b53f0@suse.com>
On Tue, Feb 15, 2022 at 08:02:35AM +0800, Qu Wenruo wrote:
>
>
> On 2022/2/15 00:15, David Sterba wrote:
> > On Fri, Feb 11, 2022 at 02:46:12PM +0800, Qu Wenruo wrote:
> >> @@ -1216,7 +1367,8 @@ static int defrag_collect_targets(struct btrfs_inode *inode,
> >> u64 range_len;
> >>
> >> last_is_target = false;
> >> - em = defrag_lookup_extent(&inode->vfs_inode, cur, locked);
> >> + em = defrag_lookup_extent(&inode->vfs_inode, cur,
> >> + ctrl->newer_than, locked);
> >
> > This uses the ctrl structure, if this is also supposed to go to 5.16
> > please provide a version that applies, thanks.
> >
>
> The conflicts are already smaller enough for this patchset and later
> autodefrag work.
>
> I can easily do a manual backport for v5.16.
So the change is to use newer_than instead of ctrl->newer_then, right?
I'll use that so it does not depend on the ctrl patches.
next prev parent reply other threads:[~2022-02-21 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 6:46 [PATCH v3 0/2] btrfs: defrag: bring back the old file extent search behavior and address merged extent map generation problem Qu Wenruo
2022-02-11 6:46 ` [PATCH v3 1/2] btrfs: defrag: bring back the old file extent search behavior Qu Wenruo
2022-02-14 16:15 ` David Sterba
2022-02-15 0:02 ` Qu Wenruo
2022-02-21 17:22 ` David Sterba [this message]
2022-02-22 0:05 ` Qu Wenruo
2022-02-11 6:46 ` [PATCH v3 2/2] btrfs: defrag: don't use merged extent map for their generation check Qu Wenruo
2022-02-11 12:07 ` [PATCH v3 0/2] btrfs: defrag: bring back the old file extent search behavior and address merged extent map generation problem Filipe Manana
2022-02-21 14:41 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221172223.GK12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox