From: David Sterba <dsterba@suse.cz>
To: Eryu Guan <guan@eryu.me>
Cc: Gabriel Niebler <gniebler@suse.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: fix btrfs/255 to fail on deadlock
Date: Wed, 23 Feb 2022 18:11:26 +0100 [thread overview]
Message-ID: <20220223171126.GQ12643@twin.jikos.cz> (raw)
In-Reply-To: <YhJ1VwUqPWkgPx2V@desktop>
On Mon, Feb 21, 2022 at 01:07:35AM +0800, Eryu Guan wrote:
> On Wed, Feb 16, 2022 at 11:05:35AM +0100, Gabriel Niebler wrote:
> > In its current implementation, the test btrfs/255 would hang forever
> > on any kernel w/o patch "btrfs: fix deadlock between quota disable
> > and qgroup rescan worker", rather than failing, as it should.
> > Fix this by introducing generous timeouts.
> >
> > Signed-off-by: Gabriel Niebler <gniebler@suse.com>
>
> If deadlock was already triggered, I don't think killing the userspace
> program with timeout will help, as the kernel already deadlocked, and
> filesystem and/or device can't be used by next test either.
>
> I think we should just exclude the test when running tests on unpatched
> kernel.
I don't see a way how to detect it at runtime, or do you mean to use the
expunge files?
next prev parent reply other threads:[~2022-02-23 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:05 [PATCH] fstests: fix btrfs/255 to fail on deadlock Gabriel Niebler
2022-02-20 17:07 ` Eryu Guan
2022-02-23 17:11 ` David Sterba [this message]
2022-03-20 15:33 ` Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2022-02-16 9:03 Gabriel Niebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223171126.GQ12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=gniebler@suse.com \
--cc=guan@eryu.me \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox