From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B515DC433EF for ; Wed, 23 Feb 2022 17:24:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243389AbiBWRZR (ORCPT ); Wed, 23 Feb 2022 12:25:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243281AbiBWRZP (ORCPT ); Wed, 23 Feb 2022 12:25:15 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF39527EA; Wed, 23 Feb 2022 09:24:48 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D315E2171F; Wed, 23 Feb 2022 17:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645637086; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nyh+dlLEFtk5a7r5fyJIdubXRNDNCA4Th/hKQraTE04=; b=U+PX8irA9nCRkeNyaYP4YauJzL5b+RpoJQz8+zIM5SQjPp6Hcqq0W8dMARHMX9s6ZdWljO ++b1pRI2TDFV14Qat3WYBscnrQvVOu7ZseP6mAe/h4jASJvjAong1fc7NCd9+4DuFYX5QU K6ilYzU/GSmuvQvs1ezsAH6XsMXGx5s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645637086; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nyh+dlLEFtk5a7r5fyJIdubXRNDNCA4Th/hKQraTE04=; b=fPZpu2fzLWkeRmqbCa1udMNPegRO86v88zz9pqguCeJ/DrwqKlzvP0qPGvRBHTh9k1GEJ5 eQzERY5e3TVSGfDw== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id A47F0A3B83; Wed, 23 Feb 2022 17:24:46 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 4BE16DA7F7; Wed, 23 Feb 2022 18:20:58 +0100 (CET) Date: Wed, 23 Feb 2022 18:20:58 +0100 From: David Sterba To: Su Yue Cc: Greg KH , Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Sterba , clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.10 16/27] btrfs: tree-checker: check item_size for dev_item Message-ID: <20220223172058.GR12643@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Su Yue , Greg KH , Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Sterba , clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org References: <20220209184103.47635-1-sashal@kernel.org> <20220209184103.47635-16-sashal@kernel.org> <1r00qtxj.fsf@damenly.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1r00qtxj.fsf@damenly.su> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Feb 18, 2022 at 07:25:20PM +0800, Su Yue wrote: > On Fri 18 Feb 2022 at 11:36, Greg KH wrote: > > On Wed, Feb 09, 2022 at 01:40:52PM -0500, Sasha Levin wrote: > \ > | ~~~~~~~~~~~~^ > fs/btrfs/ctree.h:1833:1: note: in expansion of macro > \342\200\230BTRFS_SETGET_FUNCS\342\200\231 > 1833 | BTRFS_SETGET_FUNCS(item_size, struct btrfs_item, size, > 32); > | ^~~~~~~~~~~~~~~~~~ > ======================================================================== > > The upstream patchset[1] merged in 5.17-rc1, changed second > parameter > of btrfs_item_size() from btrfs_item * to int directly. > So yes, the backport is wrong. > > I'm not familiar with stable backport progress. Should I file a > patch > using btrfs_item *? Or just drop it? > > The patch is related to 0c982944af27d131d3b74242f3528169f66950ad > but > I wonder why the 0c98294 is not selected automatically. We don't rely on the automatic selection, I evaluate all patches for stable inclusion and add the CC: tag, this works well. Not all patches need to go to stable, but AUTOSEL sometimes picks patches that could be there and if it's not entirely wrong I don't object.