From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <Naohiro.Aota@wdc.com>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"david@fromorbit.com" <david@fromorbit.com>
Subject: Re: [PATCH v3 2/2] btrfs: zoned: mark relocation as writing
Date: Mon, 28 Feb 2022 21:18:30 +0100 [thread overview]
Message-ID: <20220228201830.GK12643@twin.jikos.cz> (raw)
In-Reply-To: <20220224021558.eubg4agqnkkodkd6@naota-xeon>
On Thu, Feb 24, 2022 at 02:15:58AM +0000, Naohiro Aota wrote:
> On Wed, Feb 23, 2022 at 11:31:07AM +0100, David Sterba wrote:
> > On Fri, Feb 18, 2022 at 01:14:19PM +0900, Naohiro Aota wrote:
> It looks like this occurs when the balance is resumed. We also need
> sb_{start,end}_write around btrfs_balance() in balance_kthred().
>
> I guess we can cause a hang if we resume the balance and freeze the FS
> at the same time.
We need to fix the missing write protection before the asserts can be
added, so I'll delete them from this patch and will submit the helpers
patch once after we have fixed all.
next prev parent reply other threads:[~2022-02-28 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 4:14 [PATCH v3 0/2] btrfs: zoned: mark relocation as writing Naohiro Aota
2022-02-18 4:14 ` [PATCH v3 1/2] fs: add asserting functions for sb_start_{write,pagefault,intwrite} Naohiro Aota
2022-02-18 4:14 ` [PATCH v3 2/2] btrfs: zoned: mark relocation as writing Naohiro Aota
2022-02-18 6:13 ` Johannes Thumshirn
2022-02-23 10:31 ` David Sterba
2022-02-24 2:15 ` Naohiro Aota
2022-02-24 19:12 ` David Sterba
2022-02-28 20:18 ` David Sterba [this message]
2022-02-18 16:54 ` [PATCH v3 0/2] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228201830.GK12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox