Re: [PATCH 1/7] btrfs-progs: check: fix check_global_roots_uptodate

[David Sterba <dsterba@suse.cz>]

On Tue, Feb 22, 2022 at 05:22:36PM -0500, Josef Bacik wrote:
> While running make test on other patches I noticed we are now
> segfaulting on the fuzz tests.  This is because when I converted us to a
> rb tree for the global roots we lost the ability to catch that there's
> no extent root at all.  Before we'd populate a dummy
> fs_info->extent_root with a not uptodate node, but now you simply don't
> get an extent root in the rb_tree.  Fix the check_global_roots_uptodate
> helper to count how many roots we find and make sure it matches the
> number we expect.  If it doesn't then we can return -EIO.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  check/main.c | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
> 
> diff --git a/check/main.c b/check/main.c
> index 8ccba447..abe208df 100644
> --- a/check/main.c
> +++ b/check/main.c
> @@ -10207,6 +10207,8 @@ static int check_global_roots_uptodate(void)
>  {
>  	struct btrfs_root *root;
>  	struct rb_node *n;
> +	int found_csum = 0, found_extent = 0, found_fst = 0;
> +	int ret = 0;
>  
>  	for (n = rb_first(&gfs_info->global_roots_tree); n; n = rb_next(n)) {
>  		root = rb_entry(n, struct btrfs_root, rb_node);
> @@ -10215,9 +10217,39 @@ static int check_global_roots_uptodate(void)
>  			      root->root_key.objectid, root->root_key.offset);
>  			return -EIO;
>  		}
> +		switch(root->root_key.objectid) {
> +		case BTRFS_EXTENT_TREE_OBJECTID:
> +			found_extent++;
> +			break;
> +		case BTRFS_CSUM_TREE_OBJECTID:
> +			found_csum++;
> +			break;
> +		case BTRFS_FREE_SPACE_TREE_OBJECTID:
> +			found_fst++;
> +			break;
> +		default:
> +			break;
> +		}
>  	}
>  
> -	return 0;
> +	if (found_extent != gfs_info->nr_global_roots) {
> +		error("found %d extent roots, expected %llu\n", found_extent,

Reminder for the future, the strings for error() a warning() helpers do
not need the trailing \n.