From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs: scrub: big renaming to address the page and sector difference
Date: Thu, 10 Mar 2022 20:29:00 +0100 [thread overview]
Message-ID: <20220310192900.GD12643@twin.jikos.cz> (raw)
In-Reply-To: <cover.1645530899.git.wqu@suse.com>
On Tue, Feb 22, 2022 at 08:09:35PM +0800, Qu Wenruo wrote:
> >From the ancient day, btrfs doesn't support sectorsize < PAGE_SIZE, thus
> a lot of the old code consider one page == one sector, not only the
> behavior, but also the naming.
>
> This is no longer true after v5.16 since we have subpage support.
>
> One of the worst location is scrub, we have tons of things named like
> scrub_page, scrub_block::pagev, scrub_bio::pagev.
>
> Even scrub for subpage is supported, the naming is not touched yet.
>
> This patchset will first do the rename, providing the basis for later
> scrub enhancement for subpage.
>
> This patchset should not bring any behavior change.
>
> Qu Wenruo (3):
> btrfs: scrub: rename members related to scrub_block::pagev
> btrfs: scrub: rename scrub_page to scrub_sector
> btrfs: scrub: rename scrub_bio::pagev and related members
This conflicts with the scrub refactoring, but applies cleanly on
misc-next. I think the rename could go in first as it's a less risky
change and any fixups or fine tuning of the refactoring would not affect
it.
next prev parent reply other threads:[~2022-03-10 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 12:09 [PATCH 0/3] btrfs: scrub: big renaming to address the page and sector difference Qu Wenruo
2022-02-22 12:09 ` [PATCH 1/3] btrfs: scrub: rename members related to scrub_block::pagev Qu Wenruo
2022-02-22 12:09 ` [PATCH 2/3] btrfs: scrub: rename scrub_page to scrub_sector Qu Wenruo
2022-02-22 12:09 ` [PATCH 3/3] btrfs: scrub: rename scrub_bio::pagev and related members Qu Wenruo
2022-03-10 19:29 ` David Sterba [this message]
2022-03-10 23:26 ` [PATCH 0/3] btrfs: scrub: big renaming to address the page and sector difference Qu Wenruo
2022-03-14 19:46 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310192900.GD12643@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox