From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74970C433FE for ; Wed, 23 Mar 2022 06:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233715AbiCWGOh (ORCPT ); Wed, 23 Mar 2022 02:14:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiCWGOf (ORCPT ); Wed, 23 Mar 2022 02:14:35 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C712667; Tue, 22 Mar 2022 23:13:05 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 0790E68AFE; Wed, 23 Mar 2022 07:13:03 +0100 (CET) Date: Wed, 23 Mar 2022 07:13:02 +0100 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Josef Bacik , David Sterba , Qu Wenruo , Naohiro Aota , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 27/40] btrfs: clean up the raid map handling __btrfs_map_block Message-ID: <20220323061302.GI24302@lst.de> References: <20220322155606.1267165-1-hch@lst.de> <20220322155606.1267165-28-hch@lst.de> <0bcf1be8-cbbe-1978-9d7b-eed52ebacc57@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bcf1be8-cbbe-1978-9d7b-eed52ebacc57@gmx.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Mar 23, 2022 at 09:08:44AM +0800, Qu Wenruo wrote: > > > On 2022/3/22 23:55, Christoph Hellwig wrote: >> Clear need_raid_map early instead of repeating the same conditional over >> and over. > > I had a more comprehensive cleanup, but only for scrub: > https://lore.kernel.org/linux-btrfs/cover.1646984153.git.wqu@suse.com/ I'll take a look. I mostly wanted to avoid checking the same conditional yet again for fast path added later in this series.