From: David Sterba <dsterba@suse.cz>
To: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 0/2] btrfs: Allocate page arrays more efficiently.
Date: Mon, 28 Mar 2022 23:58:23 +0200 [thread overview]
Message-ID: <20220328215823.GV2237@twin.jikos.cz> (raw)
In-Reply-To: <cover.1648496453.git.sweettea-kernel@dorminy.me>
On Mon, Mar 28, 2022 at 04:14:26PM -0400, Sweet Tea Dorminy wrote:
> In several places, btrfs allocates an array of pages, one at a time. In
> addition to duplicating code, the mm subsystem provides a helper to
> allocate multiple pages at once into an array which is suited for our
> usecase. In the fast path, the batching can result in better allocation
> decisions and less locking. This changeset first adjusts the users to
> call a common array-of-pages allocation function, then adjusts that
> common function to use the batch page allocator.
Makes sense, the allocator internal knowledge can improve things. Though
after some time the memory often is fragmented and the bulk allocator
could fall back to single page allocation, it won't be worse than what
we already have.
I have some coding style comments, will reply under the patches,
otherwise the series looks good.
next prev parent reply other threads:[~2022-03-28 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 20:14 [PATCH 0/2] btrfs: Allocate page arrays more efficiently Sweet Tea Dorminy
2022-03-28 21:58 ` David Sterba [this message]
[not found] <cover.1648497027.git.sweettea-kernel@dorminy.me>
2022-03-28 20:14 ` [PATCH 1/2] btrfs: Factor out allocating an array of pages Sweet Tea Dorminy
2022-03-28 23:09 ` David Sterba
2022-03-30 19:01 ` Sweet Tea Dorminy
2022-03-29 10:04 ` Filipe Manana
2022-03-29 18:30 ` Nikolay Borisov
2022-03-28 20:14 ` [PATCH 2/2] btrfs: Allocate page arrays using bulk page allocator Sweet Tea Dorminy
2022-03-28 20:14 ` Sweet Tea Dorminy
2022-03-29 18:31 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328215823.GV2237@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sweettea-kernel@dorminy.me \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox