From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs-progs: check: avoid false alerts for --check-data-csum on RAID56
Date: Tue, 29 Mar 2022 23:02:37 +0200 [thread overview]
Message-ID: <20220329210237.GC2237@twin.jikos.cz> (raw)
In-Reply-To: <cover.1648546873.git.wqu@suse.com>
On Tue, Mar 29, 2022 at 05:44:24PM +0800, Qu Wenruo wrote:
> There is a long existing bug that btrfs-progs doesn't really support
> rebuilding its data using RAID56 P/Q.
>
> This means any read with mirror_num > 1 for RAID56 won't work, and will
> just return the P/Q raw data directly.
>
> The RAID56 ability in btrfs-progs is only for data write.
>
> This will cause tons of false alerts for "btrfs check
> --check-data-csum", making it useless as an offline to verify RAID56
> data.
>
> The proper fix will need way more code modification (btrfs-fuse supports
> that, so I believe it's possible).
>
> But for now, let's just disable mirror_num > 1 read repair for progs.
>
> Qu Wenruo (2):
> btrfs-progs: avoid checking wrong RAID5/6 P/Q data
> btrfs-progs: tests/fsck: add test case for data csum check on raid5
Added to devel with some fixups, thanks.
prev parent reply other threads:[~2022-03-29 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:44 [PATCH 0/2] btrfs-progs: check: avoid false alerts for --check-data-csum on RAID56 Qu Wenruo
2022-03-29 9:44 ` [PATCH 1/2] btrfs-progs: avoid checking wrong RAID5/6 P/Q data Qu Wenruo
2022-03-29 21:00 ` David Sterba
2022-03-29 9:44 ` [PATCH 2/2] btrfs-progs: tests/fsck: add test case for data csum check on raid5 Qu Wenruo
2022-03-29 21:01 ` David Sterba
2022-03-29 21:02 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329210237.GC2237@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox