From: David Sterba <dsterba@suse.cz>
To: Gabriel Niebler <gniebler@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH v2] btrfs: Turn delayed_nodes_tree into an XArray
Date: Wed, 13 Apr 2022 16:14:01 +0200 [thread overview]
Message-ID: <20220413141401.GJ15609@twin.jikos.cz> (raw)
In-Reply-To: <20220412123546.30478-1-gniebler@suse.com>
On Tue, Apr 12, 2022 at 02:35:46PM +0200, Gabriel Niebler wrote:
> … in the btrfs_root struct. Also adjust all usages of this object to use
> the XArray API.
>
> Signed-off-by: Gabriel Niebler <gniebler@suse.com>
> ---
>
> Notes:
> XArrays offer a somewhat nicer API than radix trees and were implemented
> specifically to replace the latter. They utilize the exact same underlying
> data structure, but their API is notionally easier to use, as it provides
> array semantics to the user of radix trees. The higher level API also
> takes care of locking, adding even more ease of use.
>
> The btrfs code uses radix trees in several places. This patch only
> converts the `delayed_nodes_tree` member of the btrfs_root struct.
You've put this under the --- marker which means this is not supposed to
be in the changelog (as we do for various patch revision commments) but
then there would be basically no useful changelog left. That the
conversion is done is clear, maybe there are some useful notes or
comments what changed and how, eg. the locking.
next prev parent reply other threads:[~2022-04-13 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 12:35 [PATCH v2] btrfs: Turn delayed_nodes_tree into an XArray Gabriel Niebler
2022-04-13 13:34 ` Nikolay Borisov
2022-04-14 9:26 ` Gabriel Niebler
2022-04-13 14:14 ` David Sterba [this message]
2022-04-14 9:39 ` Gabriel Niebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413141401.GJ15609@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=gniebler@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox