From: Roman Mamedov <rm@romanrm.net>
To: Gabriel Niebler <gniebler@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH v5] btrfs: Turn delayed_nodes_tree into an XArray
Date: Tue, 19 Apr 2022 21:05:51 +0500 [thread overview]
Message-ID: <20220419210551.65db356b@nvm> (raw)
In-Reply-To: <20220419155721.6702-1-gniebler@suse.com>
On Tue, 19 Apr 2022 17:57:21 +0200
Gabriel Niebler <gniebler@suse.com> wrote:
> - btrfs_init_delayed_node(node, root, ino);
> + do {
The "do" line appears one character off to the right for me, and upon
examination that's because it uses spaces for indentation instead of TABs like
all other lines. Did not check if this is the only place.
There is "checkpatch.pl" which would catch issues like this:
https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html
--
With respect,
Roman
next prev parent reply other threads:[~2022-04-19 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 15:57 [PATCH v5] btrfs: Turn delayed_nodes_tree into an XArray Gabriel Niebler
2022-04-19 16:05 ` Roman Mamedov [this message]
2022-04-19 20:23 ` David Sterba
2022-04-20 7:01 ` Nikolay Borisov
2022-04-20 7:09 ` Nikolay Borisov
2022-04-25 8:49 ` Gabriel Niebler
2022-04-25 9:28 ` Gabriel Niebler
2022-04-25 14:55 ` David Sterba
2022-04-26 7:40 ` Nikolay Borisov
2022-04-26 9:18 ` Gabriel Niebler
2022-04-26 17:52 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419210551.65db356b@nvm \
--to=rm@romanrm.net \
--cc=dsterba@suse.com \
--cc=gniebler@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox