public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix assertion failure during scrub due to block group reallocation
Date: Wed, 20 Apr 2022 16:36:22 +0200	[thread overview]
Message-ID: <20220420143622.GC1513@twin.jikos.cz> (raw)
In-Reply-To: <d3490e45-da8d-7c02-4a2e-c580cf673338@gmx.com>

On Wed, Apr 20, 2022 at 10:24:13AM +0800, Qu Wenruo wrote:
> > So make scrub skip any block group with a start offset that is less than
> > the value we expect, as that means it's a new block group that was created
> > in the current transaction. It's pointless to continue and try to scrub
> > its extents, because scrub searches for extents using the commit root, so
> > it won't find any. For a device replace, skip it as well for the same
> > reasons, and we don't need to worry about the possibility of extents of
> > the new block group not being to the new device, because we have the write
> > duplication setup done through btrfs_map_block().
> >
> > Signed-off-by: Filipe Manana <fdmanana@suse.com>
> 
> The offending commit is relatively new, do we need to Cc to stable just
> for v5.17 kernel?

If a patch already comes with a stable it's a plus but otherwise I do a
check namely for fixes, they typically go to the next rc and based on
severity of the fix get a stable tag. No big deal if it's not in the
patch, a note under the -- "this may go to stable" is also ok if you're
not sure about the exact stable version.

      parent reply	other threads:[~2022-04-20 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 13:23 [PATCH] btrfs: fix assertion failure during scrub due to block group reallocation fdmanana
2022-04-19 18:02 ` David Sterba
2022-04-20  2:24 ` Qu Wenruo
2022-04-20  9:50   ` Filipe Manana
2022-04-20  9:52     ` Qu Wenruo
2022-04-20 14:36   ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420143622.GC1513@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox