From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 07/17] btrfs: make rbio_add_io_page() subpage compatible
Date: Thu, 21 Apr 2022 18:24:22 +0200 [thread overview]
Message-ID: <20220421162422.GE18596@twin.jikos.cz> (raw)
In-Reply-To: <ec6b3ca4-87bc-64a3-075e-a2e2dcf6461a@gmx.com>
On Fri, Apr 15, 2022 at 06:28:35AM +0800, Qu Wenruo wrote:
> > I should have done that, there are way more code changes that I missed
> > when going through the patch difference manually. I'll try to port it
> > again but uh.
>
> Mind me to do the rebase?
>
> Just base all the changes to the last commit just before the branch.
>
> As doing manually diff check would also give me a deeper impression on
> what I should do in the first place to reduce your workload.
I don't push all the topic branches but they appear in for-next so you
can extract it from there, otherwise I can always push it on request so
we can sort it out.
Anyway, the branch is now merged to misc-next, and regarding the
problems I think there were a few factors that struck at the same time.
Checking diff of my changes against your branch is a safety check that
I should have done. We want to get branches for testing but patch
revisions also happen, so they can diverge and that we all stick to the
same coding style and formatting preferences is a noble goal but
practicaly not 100% achievable, there's always something left.
next prev parent reply other threads:[~2022-04-21 16:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:32 [PATCH v2 00/17] btrfs: add subpage support for RAID56 Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 01/17] btrfs: reduce width for stripe_len from u64 to u32 Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 02/17] btrfs: open-code rbio_nr_pages() Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 03/17] btrfs: make btrfs_raid_bio more compact Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 04/17] btrfs: introduce new cached members for btrfs_raid_bio Qu Wenruo
2022-04-15 5:31 ` Christoph Hellwig
2022-04-15 5:34 ` Qu Wenruo
2022-04-15 5:45 ` Christoph Hellwig
2022-04-12 9:32 ` [PATCH v2 05/17] btrfs: introduce btrfs_raid_bio::stripe_sectors Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 06/17] btrfs: introduce btrfs_raid_bio::bio_sectors Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 07/17] btrfs: make rbio_add_io_page() subpage compatible Qu Wenruo
2022-04-13 19:14 ` David Sterba
2022-04-13 23:28 ` Qu Wenruo
2022-04-14 0:43 ` Qu Wenruo
2022-04-14 10:59 ` Qu Wenruo
2022-04-14 15:51 ` David Sterba
2022-04-14 22:48 ` Qu Wenruo
2022-04-21 15:44 ` David Sterba
2022-04-14 15:43 ` David Sterba
2022-04-14 17:51 ` David Sterba
2022-04-14 22:28 ` Qu Wenruo
2022-04-21 16:24 ` David Sterba [this message]
2022-04-12 9:32 ` [PATCH v2 08/17] btrfs: make finish_parity_scrub() " Qu Wenruo
2022-04-12 9:32 ` [PATCH v2 09/17] btrfs: make __raid_recover_endio_io() subpage compatibable Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 10/17] btrfs: make finish_rmw() subpage compatible Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 11/17] btrfs: open-code rbio_stripe_page_index() Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 12/17] btrfs: make raid56_add_scrub_pages() subpage compatible Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 13/17] btrfs: remove btrfs_raid_bio::bio_pages array Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 14/17] btrfs: make set_bio_pages_uptodate() subpage compatible Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 15/17] btrfs: make steal_rbio() " Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 16/17] btrfs: make alloc_rbio_essential_pages() " Qu Wenruo
2022-04-12 9:33 ` [PATCH v2 17/17] btrfs: enable subpage support for RAID56 Qu Wenruo
2022-04-12 17:42 ` [PATCH v2 00/17] btrfs: add " David Sterba
2022-04-13 14:46 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421162422.GE18596@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox