From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: simplify WQ_HIGHPRI handling in struct btrfs_workqueue
Date: Sat, 23 Apr 2022 07:45:42 +0200 [thread overview]
Message-ID: <20220423054542.GB17823@lst.de> (raw)
In-Reply-To: <20220422210525.GL18596@twin.jikos.cz>
On Fri, Apr 22, 2022 at 11:05:25PM +0200, David Sterba wrote:
> On Mon, Apr 18, 2022 at 04:03:43PM +0800, Qu Wenruo wrote:
> > > -struct __btrfs_workqueue {
> > > +struct btrfs_workqueue {
> > > struct workqueue_struct *normal_wq;
> >
> > I guess we can also rename @normal_wq here, as there is only one wq in
> > each btrfs_workqueue, no need to distinguish them in btrfs_workqueue.
>
> Yeah now the 'normal_' prefix does not make sense.
I though it always was about the btrfs wrapper vs kernel
implementaiton. I.e. even the hipri one used normal inside the
__btrfs_workqueue.
> /* size: 88, cachelines: 2, members: 7 */
> /* last cacheline: 24 bytes */
> };
>
> The fs_info structure grew a bit but it's a large one and there's still
> enough space before it hits 4K.
The only growth should be a single pointer for thew new hipri submission
work queue. But if the fs_info size is a concern I'm pretty sure there
is a lot of low hanging fruit.
next prev parent reply other threads:[~2022-04-23 5:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 4:43 btrfs_workqueue cleanups Christoph Hellwig
2022-04-18 4:43 ` [PATCH 1/3] btrfs: simplify WQ_HIGHPRI handling in struct btrfs_workqueue Christoph Hellwig
2022-04-18 8:03 ` Qu Wenruo
2022-04-22 21:05 ` David Sterba
2022-04-22 22:58 ` Qu Wenruo
2022-04-23 5:45 ` Christoph Hellwig [this message]
2022-04-18 4:43 ` [PATCH 2/3] btrfs: use normal workqueues for scrub Christoph Hellwig
2022-04-18 8:04 ` Qu Wenruo
2022-04-18 4:43 ` [PATCH 3/3] btrfs: use a normal workqueue for rmw_workers Christoph Hellwig
2022-04-18 8:05 ` Qu Wenruo
2022-04-22 21:22 ` btrfs_workqueue cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423054542.GB17823@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox